Skip to content

V2: Add Servers param - #1573

Merged
Nerzal merged 3 commits into
v2from
servers-param
May 4, 2023
Merged

Nerzal merged 3 commits into
v2from
servers-param

Conversation

@Nerzal

@Nerzal Nerzal commented May 3, 2023 •

Copy link
Copy Markdown
Contributor

Describe the PR
Adding the @servers param to fill the servers object.

Relation issue
None.

Additional context
The additional properties of the object can be implemented in the future. This PR only targets the basic functionality.
This PR is based on the branch of #1572 and should therefor be merged after.

@Nerzal Nerzal added the v2 Used for all v2 related issues label May 3, 2023
@codecov

codecov Bot commented May 3, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage: 19.44% and project coverage change: -0.15 ⚠️

Comparison is base (ff9485a) 79.52% compared to head (1f57fc3) 79.38%.

❗ Current head 1f57fc3 differs from pull request most recent head 879c559. Consider uploading reports for the commit 879c559 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##               v2    #1573      +/-   ##
==========================================
- Coverage   79.52%   79.38%   -0.15%     
==========================================
  Files          21       21              
  Lines        5549     5568      +19     
==========================================
+ Hits         4413     4420       +7     
- Misses        962      974      +12     
  Partials      174      174              
Impacted Files Coverage Δ
gen/gen.go 70.52% <0.00%> (-0.95%) ⬇️
parserv3.go 74.09% <46.66%> (-0.70%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ubogdan ubogdan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nerzal
Nerzal merged commit c7b796d into v2 May 4, 2023
@Nerzal
Nerzal deleted the servers-param branch May 4, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v2 Used for all v2 related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ 换网址