Skip to content

V2: Fix template delims - #1572

Merged
Nerzal merged 2 commits into
v2from
fix-template-delims
May 4, 2023
Merged

Nerzal merged 2 commits into
v2from
fix-template-delims

Conversation

@Nerzal

@Nerzal Nerzal commented May 3, 2023

Copy link
Copy Markdown
Contributor

Describe the PR
Fixed an error, that caused the docs.go to not be generated.

Relation issue
None.

Additional context
Also fixed incorrect error return in genv3

@codecov

codecov Bot commented May 3, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage has no change and project coverage change: -0.06 ⚠️

Comparison is base (ff9485a) 79.52% compared to head (8fd4d46) 79.47%.

❗ Current head 8fd4d46 differs from pull request most recent head 80752b1. Consider uploading reports for the commit 80752b1 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##               v2    #1572      +/-   ##
==========================================
- Coverage   79.52%   79.47%   -0.06%     
==========================================
  Files          21       21              
  Lines        5549     5553       +4     
==========================================
  Hits         4413     4413              
- Misses        962      966       +4     
  Partials      174      174              
Impacted Files Coverage Δ
gen/gen.go 70.52% <0.00%> (-0.95%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Nerzal Nerzal mentioned this pull request May 3, 2023
@Nerzal Nerzal added the v2 Used for all v2 related issues label May 3, 2023
@Nerzal
Nerzal merged commit 9a872fb into v2 May 4, 2023
@Nerzal
Nerzal deleted the fix-template-delims branch May 4, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v2 Used for all v2 related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ 换网址