Skip to content

fix: manifest diff shows all resources as recreated (#672) - #673

Merged
undera merged 1 commit into
mainfrom
fix/manifest-diff-regression
Mar 27, 2026
Merged

undera merged 1 commit into
mainfrom
fix/manifest-diff-regression

Conversation

@undera

@undera undera commented Mar 27, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Fixes Manifest diff shows all resources as recreated after upgrade to 2.1.0 #672 — manifest diff regression in v2.1.0 where all resources appear as newly created
  • useGetReleaseManifest was using fetchWithSafeDefaults which drops text/plain responses (returns fallback [] instead of YAML string)
  • Reverted to fetchWithDefaults which correctly passes through text/plain YAML from the /manifests endpoint

Test plan

  • Reproduced on local kind cluster with a deployed helm release
  • Verified /api/helm/releases/<ns>/<name>/manifests returns text/plain YAML (6594 bytes)
  • Confirmed tsc --noEmit passes cleanly
  • Verify in browser: Upgrade dialog → Manifest changes tab shows only actual diff, not all resources as new

🤖 Generated with Claude Code

The manifests endpoint returns text/plain YAML, but fetchWithSafeDefaults
treats string responses as errors and returns the fallback value ([]).
Revert useGetReleaseManifest to use fetchWithDefaults which correctly
passes through text/plain responses.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@undera

undera commented Mar 27, 2026

Copy link
Copy Markdown
Collaborator Author

Root cause: introduced by @yuri-sakharov on Dec 1, 2025 in commit f2eb91b (PR #632 "Enabled recommended-requiring-type-checking as result type fixes provided").

That was a bulk refactor switching fetchWithDefaults → fetchWithSafeDefaults to satisfy TypeScript type-checking. The /manifests endpoint intentionally returns text/plain YAML, but fetchWithSafeDefaults treats any string response as an error and returns the fallback ([]), silently dropping the manifest data.

@undera
undera marked this pull request as ready for review March 27, 2026 11:00
@undera
undera merged commit 81e9829 into main Mar 27, 2026
4 checks passed
@undera
undera deleted the fix/manifest-diff-regression branch March 27, 2026 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Manifest diff shows all resources as recreated after upgrade to 2.1.0

1 participant

⌂ 换网址