Skip to content

Manifest diff shows all resources as recreated after upgrade to 2.1.0 #672

Closed

Description

@iva3682

Description

Version: 2.1.0 (regression from 2.0.4)

Description

After upgrading helm-dashboard from 2.0.4 to 2.1.0, the Manifest changes
dialog (current.yaml → upgraded.yaml) shows all Kubernetes resources as
newly created instead of showing only the actual diff.

Steps to Reproduce

  1. Install helm-dashboard 2.1.0
  2. Open any deployed Helm release
  3. Click "Upgrade" and select a new chart version
  4. Open the "Manifest changes" tab

Expected Behavior

Only changed resources/fields are highlighted (as in v2.0.4).

Actual Behavior

All resources are shown as new additions — as if the current release has
no manifest at all.

Root Cause (bisected)

The /api/helm/releases/<ns>/<name>/manifests endpoint returns text/plain
YAML. In v2.1.0, useGetReleaseManifest was switched from fetchWithDefaults
to fetchWithSafeDefaults (frontend/src/API/releases.ts).

fetchWithSafeDefaults treats any string response as an error and returns
the fallback value ([]):

if (typeof data === "string") {
  console.error(url, " response is string");
  return fallback; // returns [] instead of the YAML string
}

As a result, the current manifest is passed to the /diff endpoint as an
empty string (a=""), so the diff shows every resource as a new addition.

Fix
In frontend/src/API/releases.ts, revert useGetReleaseManifest to use
fetchWithDefaults instead of fetchWithSafeDefaults, since this endpoint
intentionally returns text/plain and not JSON.

Workaround
Downgrade to v2.0.4:

Screenshots

No response

Additional information

No response

Activity

  1. undera commented on Mar 27, 2026

    @undera
    Collaborator

    Thanks for reporting it! I released 2.1.1 with the fix

  2. east4ming commented on Mar 29, 2026

    @east4ming

    I encountered the same problem. Now I dare not upgrade the helm chart through Helm-Dashboard, fearing the introduction of unknown accidents.

  3. undera commented on Mar 29, 2026

    @undera
    Collaborator

    The issue were purely in frontend presentation of empty diff, no backend Helm logic was involved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      ⌂ 换网址