Repository navigation
say where a machine is made: the provider's full name, local or cloud - #1239
Merged
Merged
Conversation
"Creating X on ac" and "Creating VM..." said nothing about where the machine goes. A table of provider places (cmd/providerplace.go) gives every provider its full name and kind -- made on this machine (ac, fc, ch), a public cloud (aws, hetzner, azure, gcp, ovh) or elsewhere (static, boxes) -- and the create lines of onctl create and onctl claude read from it: "Creating demo as an Apple container on this machine...", "Creating demo in the cloud on Hetzner Cloud...", "Creating demo on the boxes service (claude-agent, small)...". Replaces the ac-only wording of #1238. Claude-Session: https://claude.ai/code/session_01FGfFdYSzrrKe3ySAVMPSNR
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1239 +/- ##
==========================================
+ Coverage 47.53% 47.57% +0.04%
==========================================
Files 80 81 +1
Lines 9333 9341 +8
==========================================
+ Hits 4436 4444 +8
Misses 4897 4897 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating X on acandCreating VM...said nothing about where the machine goes. A table of provider places (cmd/providerplace.go) gives every provider its full name and kind -- made on this machine (ac, fc, ch), a public cloud (aws, hetzner, azure, gcp, ovh) or elsewhere (static, boxes) -- and the create lines ofonctl createandonctl clauderead from it:Creating demo as an Apple container on this machine...Creating demo as a Firecracker microVM on this machine...Creating demo in the cloud on Hetzner Cloud...Creating demo on the boxes service (claude-agent, small)...Replaces the ac-only wording of #1238.
TestProviderPlaceschecks every provider in the list has an entry, so a new provider can't fall back to its short name unnoticed;TestCreatingMessagecovers each kind.🤖 Generated with Claude Code
https://claude.ai/code/session_01FGfFdYSzrrKe3ySAVMPSNR