Repository navigation
ac: say the sandbox is an Apple container on this Mac, not "on ac" - #1238
Merged
Merged
Conversation
"Creating onctl-templates-add-one-line-858a on ac..." read like a cloud region. On ac the sandbox is an Apple container made on the Mac the command runs on, and the line now says that; other providers keep their name as the place. onctl create's "Creating VM..." takes the same line, so it names the VM and, on ac, says where it goes. Claude-Session: https://claude.ai/code/session_01FGfFdYSzrrKe3ySAVMPSNR
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1238 +/- ##
==========================================
+ Coverage 47.51% 47.53% +0.01%
==========================================
Files 80 80
Lines 9330 9333 +3
==========================================
+ Hits 4433 4436 +3
Misses 4897 4897 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
cdalar
added a commit
that referenced
this pull request
Oct 26, 2026
"Creating X on ac" and "Creating VM..." said nothing about where the machine goes. A table of provider places (cmd/providerplace.go) gives every provider its full name and kind -- made on this machine (ac, fc, ch), a public cloud (aws, hetzner, azure, gcp, ovh) or elsewhere (static, boxes) -- and the create lines of onctl create and onctl claude read from it: "Creating demo as an Apple container on this machine...", "Creating demo in the cloud on Hetzner Cloud...", "Creating demo on the boxes service (claude-agent, small)...". Replaces the ac-only wording of #1238. Claude-Session: https://claude.ai/code/session_01FGfFdYSzrrKe3ySAVMPSNR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating onctl-templates-add-one-line-858a on ac...read like a cloud region. On ac the sandbox is an Apple container made on the Mac the command runs on, and the line now says that:Creating <name> as an Apple container on this Mac.... Other providers keep their name as the place.onctl create's genericCreating VM...uses the same line, so it names the VM and, on ac, says where it goes.Test:
TestCreatingMessage.🤖 Generated with Claude Code
https://claude.ai/code/session_01FGfFdYSzrrKe3ySAVMPSNR