Skip to content

ac: say the sandbox is an Apple container on this Mac, not "on ac" - #1238

Merged
cdalar merged 1 commit into
mainfrom
ac-local-wording
Oct 26, 2026
Merged

cdalar merged 1 commit into
mainfrom
ac-local-wording

Conversation

@cdalar

@cdalar cdalar commented Oct 26, 2026

Copy link
Copy Markdown
Owner

Creating onctl-templates-add-one-line-858a on ac... read like a cloud region. On ac the sandbox is an Apple container made on the Mac the command runs on, and the line now says that: Creating <name> as an Apple container on this Mac.... Other providers keep their name as the place.

onctl create's generic Creating VM... uses the same line, so it names the VM and, on ac, says where it goes.

Test: TestCreatingMessage.

🤖 Generated with Claude Code

https://claude.ai/code/session_01FGfFdYSzrrKe3ySAVMPSNR

"Creating onctl-templates-add-one-line-858a on ac..." read like a cloud
region. On ac the sandbox is an Apple container made on the Mac the
command runs on, and the line now says that; other providers keep their
name as the place. onctl create's "Creating VM..." takes the same line,
so it names the VM and, on ac, says where it goes.

Claude-Session: https://claude.ai/code/session_01FGfFdYSzrrKe3ySAVMPSNR
@codecov

codecov Bot commented Oct 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.53%. Comparing base (6cb86d1) to head (0f93977).

Files with missing lines Patch % Lines
cmd/claudevm.go 75.00% 1 Missing ⚠️
cmd/create.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1238      +/-   ##
==========================================
+ Coverage   47.51%   47.53%   +0.01%     
==========================================
  Files          80       80              
  Lines        9330     9333       +3     
==========================================
+ Hits         4433     4436       +3     
  Misses       4897     4897              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cdalar
cdalar merged commit b8baaeb into main Oct 26, 2026
14 checks passed
@cdalar
cdalar deleted the ac-local-wording branch October 26, 2026 07:28
cdalar added a commit that referenced this pull request Oct 26, 2026
"Creating X on ac" and "Creating VM..." said nothing about where the
machine goes. A table of provider places (cmd/providerplace.go) gives
every provider its full name and kind -- made on this machine (ac, fc,
ch), a public cloud (aws, hetzner, azure, gcp, ovh) or elsewhere (static,
boxes) -- and the create lines of onctl create and onctl claude read from
it: "Creating demo as an Apple container on this machine...", "Creating
demo in the cloud on Hetzner Cloud...", "Creating demo on the boxes
service (claude-agent, small)...". Replaces the ac-only wording of #1238.

Claude-Session: https://claude.ai/code/session_01FGfFdYSzrrKe3ySAVMPSNR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

⌂ 换网址