Skip to content

Fix mutiple "pedantic" compiler warnings, mostly around unused parameters - #347

Merged
PJK merged 15 commits into
masterfrom
warnings
Mar 15, 2025
Merged

Fix mutiple "pedantic" compiler warnings, mostly around unused parameters#347
PJK merged 15 commits into
masterfrom
warnings

Conversation

@PJK

@PJK PJK commented Mar 15, 2025

Copy link
Copy Markdown
Owner

These were missed since it turns out we need all of "-pedantic -Wall -Wextra" to get gcc to talk

@codecov

codecov Bot commented Mar 15, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 94.89559% with 22 lines in your changes missing coverage. Please review.

Project coverage is 98.57%. Comparing base (30b972c) to head (7a7f60b).
Report is 58 commits behind head on master.

Files with missing lines Patch % Lines
src/cbor/serialization.c 57.57% 14 Missing ⚠️
src/cbor.c 83.33% 4 Missing ⚠️
src/cbor/floats_ctrls.c 95.55% 2 Missing ⚠️
src/cbor/ints.c 95.83% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #347      +/-   ##
==========================================
- Coverage   99.87%   98.57%   -1.31%     
==========================================
  Files          20       20              
  Lines        1662     1684      +22     
==========================================
  Hits         1660     1660              
- Misses          2       24      +22

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@PJK
PJK merged commit 31920a4 into master Mar 15, 2025
@PJK
PJK deleted the warnings branch March 15, 2025 21:47
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Mar 30, 2025
adam
libcbor: updated to 0.12.0
a449228 
0.12.0 (2025-03-16)

- BUILD BREAKING: [Respect `INTERPROCEDURAL_OPTIMIZATION` and use the default value](PJK/libcbor#315)
- BREAKING: Changes to NaN encoding
  - [Fix NaN encoding on Windows](PJK/libcbor#271)
  - [Fix NaN encoding on mips/mipsel](PJK/libcbor#329)
  - [Signaling NaNs will from now on be encoded as canonical quiet NaNs](PJK/libcbor#335). This was already the existing behavior for half-precision floats
  - Decoding is unchanged
  - Please note that this is an intermediate state and likely to be revisited (PJK/libcbor#336)
- [Make build compatible with CMake FetchContent](PJK/libcbor#341) (by [Jan200101](https://github.com/Jan200101))
- [Support Bzlmod for Bazel builds](PJK/libcbor#340)
  - This should significantly simplify including libcbor as a dependency/module in Bazel projects, see https://bazel.build/external/migration
- Code quality improvements
  - [Fix compiler pragmas](PJK/libcbor#347) (by [brooksdavis](https://github.com/brooksdavis))
  - [Fix code style issues](PJK/libcbor#321)
- [Fixed bug in cbor2cjson example](PJK/libcbor#338)
msk pushed a commit to msk/pkgsrc that referenced this pull request May 11, 2026
adam
libcbor: updated to 0.12.0
d2c59e7 
0.12.0 (2025-03-16)

- BUILD BREAKING: [Respect `INTERPROCEDURAL_OPTIMIZATION` and use the default value](PJK/libcbor#315)
- BREAKING: Changes to NaN encoding
  - [Fix NaN encoding on Windows](PJK/libcbor#271)
  - [Fix NaN encoding on mips/mipsel](PJK/libcbor#329)
  - [Signaling NaNs will from now on be encoded as canonical quiet NaNs](PJK/libcbor#335). This was already the existing behavior for half-precision floats
  - Decoding is unchanged
  - Please note that this is an intermediate state and likely to be revisited (PJK/libcbor#336)
- [Make build compatible with CMake FetchContent](PJK/libcbor#341) (by [Jan200101](https://github.com/Jan200101))
- [Support Bzlmod for Bazel builds](PJK/libcbor#340)
  - This should significantly simplify including libcbor as a dependency/module in Bazel projects, see https://bazel.build/external/migration
- Code quality improvements
  - [Fix compiler pragmas](PJK/libcbor#347) (by [brooksdavis](https://github.com/brooksdavis))
  - [Fix code style issues](PJK/libcbor#321)
- [Fixed bug in cbor2cjson example](PJK/libcbor#338)
jperkin pushed a commit to TritonDataCenter/pkgsrc that referenced this pull request May 14, 2026
adam
libcbor: updated to 0.12.0
97c135b 
0.12.0 (2025-03-16)

- BUILD BREAKING: [Respect `INTERPROCEDURAL_OPTIMIZATION` and use the default value](PJK/libcbor#315)
- BREAKING: Changes to NaN encoding
  - [Fix NaN encoding on Windows](PJK/libcbor#271)
  - [Fix NaN encoding on mips/mipsel](PJK/libcbor#329)
  - [Signaling NaNs will from now on be encoded as canonical quiet NaNs](PJK/libcbor#335). This was already the existing behavior for half-precision floats
  - Decoding is unchanged
  - Please note that this is an intermediate state and likely to be revisited (PJK/libcbor#336)
- [Make build compatible with CMake FetchContent](PJK/libcbor#341) (by [Jan200101](https://github.com/Jan200101))
- [Support Bzlmod for Bazel builds](PJK/libcbor#340)
  - This should significantly simplify including libcbor as a dependency/module in Bazel projects, see https://bazel.build/external/migration
- Code quality improvements
  - [Fix compiler pragmas](PJK/libcbor#347) (by [brooksdavis](https://github.com/brooksdavis))
  - [Fix code style issues](PJK/libcbor#321)
- [Fixed bug in cbor2cjson example](PJK/libcbor#338)
tsutsui pushed a commit to tsutsui/pkgsrc that referenced this pull request Oct 17, 2026
adam
libcbor: updated to 0.12.0
7c4c095 
0.12.0 (2025-03-16)

- BUILD BREAKING: [Respect `INTERPROCEDURAL_OPTIMIZATION` and use the default value](PJK/libcbor#315)
- BREAKING: Changes to NaN encoding
  - [Fix NaN encoding on Windows](PJK/libcbor#271)
  - [Fix NaN encoding on mips/mipsel](PJK/libcbor#329)
  - [Signaling NaNs will from now on be encoded as canonical quiet NaNs](PJK/libcbor#335). This was already the existing behavior for half-precision floats
  - Decoding is unchanged
  - Please note that this is an intermediate state and likely to be revisited (PJK/libcbor#336)
- [Make build compatible with CMake FetchContent](PJK/libcbor#341) (by [Jan200101](https://github.com/Jan200101))
- [Support Bzlmod for Bazel builds](PJK/libcbor#340)
  - This should significantly simplify including libcbor as a dependency/module in Bazel projects, see https://bazel.build/external/migration
- Code quality improvements
  - [Fix compiler pragmas](PJK/libcbor#347) (by [brooksdavis](https://github.com/brooksdavis))
  - [Fix code style issues](PJK/libcbor#321)
- [Fixed bug in cbor2cjson example](PJK/libcbor#338)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@PJK
⌂ 换网址