Skip to content

include project directory with target instead of globally - #341

Merged
PJK merged 1 commit into
PJK:masterfrom
Jan200101:PR/fixed-target-include
Mar 4, 2025
Merged

PJK merged 1 commit into
PJK:masterfrom
Jan200101:PR/fixed-target-include

Conversation

@Jan200101

Copy link
Copy Markdown
Contributor

Description

adds the PROJECT_BINARY_DIR include directly to the cbor target instead of using include_directories.

include_directories is limited to the current CMakeLists.txt and anything loaded under it, this makes it impossible to use libcbor as a submodule or via FetchContent since the include path never gets propagated.

Checklist

  • I have read followed CONTRIBUTING.md
    • I have added tests
    • I have updated the documentation
    • I have updated the CHANGELOG
  • Are there any breaking changes?
    • If yes: I have marked them in the CHANGELOG (example)
  • Does this PR introduce any platform specific code?
  • Security: Does this PR potentially affect security?
  • Performance: Does this PR potentially affect performance?

@PJK

PJK commented Mar 4, 2025

Copy link
Copy Markdown
Owner

Thanks!

@PJK
PJK merged commit 325bfcc into PJK:master Mar 4, 2025
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Mar 30, 2025
0.12.0 (2025-03-16)

- BUILD BREAKING: [Respect `INTERPROCEDURAL_OPTIMIZATION` and use the default value](PJK/libcbor#315)
- BREAKING: Changes to NaN encoding
  - [Fix NaN encoding on Windows](PJK/libcbor#271)
  - [Fix NaN encoding on mips/mipsel](PJK/libcbor#329)
  - [Signaling NaNs will from now on be encoded as canonical quiet NaNs](PJK/libcbor#335). This was already the existing behavior for half-precision floats
  - Decoding is unchanged
  - Please note that this is an intermediate state and likely to be revisited (PJK/libcbor#336)
- [Make build compatible with CMake FetchContent](PJK/libcbor#341) (by [Jan200101](https://github.com/Jan200101))
- [Support Bzlmod for Bazel builds](PJK/libcbor#340)
  - This should significantly simplify including libcbor as a dependency/module in Bazel projects, see https://bazel.build/external/migration
- Code quality improvements
  - [Fix compiler pragmas](PJK/libcbor#347) (by [brooksdavis](https://github.com/brooksdavis))
  - [Fix code style issues](PJK/libcbor#321)
- [Fixed bug in cbor2cjson example](PJK/libcbor#338)
msk pushed a commit to msk/pkgsrc that referenced this pull request May 11, 2026
0.12.0 (2025-03-16)

- BUILD BREAKING: [Respect `INTERPROCEDURAL_OPTIMIZATION` and use the default value](PJK/libcbor#315)
- BREAKING: Changes to NaN encoding
  - [Fix NaN encoding on Windows](PJK/libcbor#271)
  - [Fix NaN encoding on mips/mipsel](PJK/libcbor#329)
  - [Signaling NaNs will from now on be encoded as canonical quiet NaNs](PJK/libcbor#335). This was already the existing behavior for half-precision floats
  - Decoding is unchanged
  - Please note that this is an intermediate state and likely to be revisited (PJK/libcbor#336)
- [Make build compatible with CMake FetchContent](PJK/libcbor#341) (by [Jan200101](https://github.com/Jan200101))
- [Support Bzlmod for Bazel builds](PJK/libcbor#340)
  - This should significantly simplify including libcbor as a dependency/module in Bazel projects, see https://bazel.build/external/migration
- Code quality improvements
  - [Fix compiler pragmas](PJK/libcbor#347) (by [brooksdavis](https://github.com/brooksdavis))
  - [Fix code style issues](PJK/libcbor#321)
- [Fixed bug in cbor2cjson example](PJK/libcbor#338)
jperkin pushed a commit to TritonDataCenter/pkgsrc that referenced this pull request May 14, 2026
0.12.0 (2025-03-16)

- BUILD BREAKING: [Respect `INTERPROCEDURAL_OPTIMIZATION` and use the default value](PJK/libcbor#315)
- BREAKING: Changes to NaN encoding
  - [Fix NaN encoding on Windows](PJK/libcbor#271)
  - [Fix NaN encoding on mips/mipsel](PJK/libcbor#329)
  - [Signaling NaNs will from now on be encoded as canonical quiet NaNs](PJK/libcbor#335). This was already the existing behavior for half-precision floats
  - Decoding is unchanged
  - Please note that this is an intermediate state and likely to be revisited (PJK/libcbor#336)
- [Make build compatible with CMake FetchContent](PJK/libcbor#341) (by [Jan200101](https://github.com/Jan200101))
- [Support Bzlmod for Bazel builds](PJK/libcbor#340)
  - This should significantly simplify including libcbor as a dependency/module in Bazel projects, see https://bazel.build/external/migration
- Code quality improvements
  - [Fix compiler pragmas](PJK/libcbor#347) (by [brooksdavis](https://github.com/brooksdavis))
  - [Fix code style issues](PJK/libcbor#321)
- [Fixed bug in cbor2cjson example](PJK/libcbor#338)
tsutsui pushed a commit to tsutsui/pkgsrc that referenced this pull request Oct 17, 2026
0.12.0 (2025-03-16)

- BUILD BREAKING: [Respect `INTERPROCEDURAL_OPTIMIZATION` and use the default value](PJK/libcbor#315)
- BREAKING: Changes to NaN encoding
  - [Fix NaN encoding on Windows](PJK/libcbor#271)
  - [Fix NaN encoding on mips/mipsel](PJK/libcbor#329)
  - [Signaling NaNs will from now on be encoded as canonical quiet NaNs](PJK/libcbor#335). This was already the existing behavior for half-precision floats
  - Decoding is unchanged
  - Please note that this is an intermediate state and likely to be revisited (PJK/libcbor#336)
- [Make build compatible with CMake FetchContent](PJK/libcbor#341) (by [Jan200101](https://github.com/Jan200101))
- [Support Bzlmod for Bazel builds](PJK/libcbor#340)
  - This should significantly simplify including libcbor as a dependency/module in Bazel projects, see https://bazel.build/external/migration
- Code quality improvements
  - [Fix compiler pragmas](PJK/libcbor#347) (by [brooksdavis](https://github.com/brooksdavis))
  - [Fix code style issues](PJK/libcbor#321)
- [Fixed bug in cbor2cjson example](PJK/libcbor#338)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ 换网址