You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
(I'm on VSCode 1.24.1)
iTerm2 has this really nice feature where you can enforce a minimum level of contrast, which is invaluable to making sure that all text shows up, regardless of color scheme / background color.
For example, the text to the right is basically unreadable, unless I select it, in which case it becomes marginally readable.
It would be awesome to have an option to enforce a minimum level of contrast.
I guess this could be an opt-in setting which overrides the foreground color and if necessary the background color too?
Foreground and background are done in 2 passes so it might get tricky how to influence both. Perhaps only changing one or the other would be better? This should be done in the TextRenderLayer:
Activity
Tyriar commentedon Jun 15, 2018
I guess this could be an opt-in setting which overrides the foreground color and if necessary the background color too?
Foreground and background are done in 2 passes so it might get tricky how to influence both. Perhaps only changing one or the other would be better? This should be done in the
TextRenderLayer:xterm.js/src/renderer/TextRenderLayer.ts
Line 214 in 4717619
xterm.js/src/renderer/TextRenderLayer.ts
Line 196 in 4717619
jaredly commentedon Jun 15, 2018
I think that iterm2 only modifies the foreground color, and I think that should be sufficient