Repository navigation
Agent picker: search by status, session and tab, not messages - #3
Merged
Merged
Conversation
Typing in the agent picker matched letters scattered through agents'
long messages ("public" in "...blocked from merging because..."), and
fzf scrolled those rows sideways to show the match, hiding their session
and tab: they read as stray wrapped lines.
agent list --ids now ends the status, session and tab with a tab, and the
picker only searches that column (--nth 1), drawing tabs one column wide
so rows stay aligned.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Benchmarks 📊Note No benchmark moved. Compared 96 measurements. How this was measuredBefore
After
linux/amd64 · AMD EPYC 7763 64-Core Processor benchstat tableInformational: this job never fails on a regression. See CONTRIBUTING.md ("Benchmarks"). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Typing in the agent picker (
contrib/ksesh-agents-fzf) also searched the agents' long messages. "public" matched letters scattered through a message ("…blocked from merging because…"). fzf then scrolled those rows sideways to show the match, which hid their session and tab, so they looked like stray wrapped lines.ksesh agent list --idsnow puts a tab after the status, session and tab title.--with-nth 3.. --nth 1) and shows tabs one column wide (--tabstop 1), so rows stay aligned. The search box hint now reads "filter by status, session or tab".Stacked on #2. Merge that first; this PR's base will then move to
main.Test plan
go test ./seshcli/passes, including a new test for the column split.fzf --filter publicmatches only the 3 agents whose session is named public. Before, it matched 5, two of them through their messages.🤖 Generated with Claude Code