You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Oct 25, 2020. It is now read-only.
Repository navigation
This repository was archived by the owner on Oct 25, 2020. It is now read-only.
App just pass to editor controls over console and wait till it's done and pass it back so we would knew when values.toml is ready.
We can resolve this by manual copying values.toml and call ska with value parameter #24. Or command that's copies values.toml and overrides whole step with editor invocation if values.toml detected in current directory.
Yep, I use vim personally (at least for shell editor) so i've never hit this either, but I'm trying to make a somewhat newbie-friendly set of templates on the current project I'm working on and a co-worker hit this, sadly.
So some extra info from https://stackoverflow.com/a/36644561/59058 makes me think this should work with either code --wait or at least code -n --wait, but doesn't seem to be a good way to set that as $EDITOR directly (for git you do it via git config core.editor instead of just $EDITOR). I was able to make a file called codewait.sh with just this in it:
#!/bin/bash
code --wait -n $@
And when I set that codewait.sh script as $EDITOR it worked fine... could either just document this, or special-case it if $EDITOR is code (since that does seem to be a popular choice these days).
Activity
xdefrag commentedon Jun 7, 2019
@ysamlan I don't use vscode myself, tested this app only with emacs and vim. Just checked it and bumped into same behavior. Would investigate further.
xdefrag commentedon Jun 8, 2019
I get it. Ska works well with any console editor and doesn't work with visual one because that's how editor invoked:
App just pass to editor controls over console and wait till it's done and pass it back so we would knew when values.toml is ready.
We can resolve this by manual copying values.toml and call ska with value parameter #24. Or command that's copies values.toml and overrides whole step with editor invocation if values.toml detected in current directory.
ysamlan commentedon Jun 10, 2019
Yep, I use
vimpersonally (at least for shell editor) so i've never hit this either, but I'm trying to make a somewhat newbie-friendly set of templates on the current project I'm working on and a co-worker hit this, sadly.So some extra info from https://stackoverflow.com/a/36644561/59058 makes me think this should work with either
code --waitor at leastcode -n --wait, but doesn't seem to be a good way to set that as $EDITOR directly (forgityou do it viagit config core.editorinstead of just$EDITOR). I was able to make a file calledcodewait.shwith just this in it:And when I set that
codewait.shscript as $EDITOR it worked fine... could either just document this, or special-case it if $EDITOR iscode(since that does seem to be a popular choice these days).