Skip to content

fix(urlchecker): convert timeout value to time.Second - #2182

Merged
FelicianoTech merged 1 commit into
wtfutil:trunkfrom
kgehmlich:trunk
Sep 29, 2026
Merged

FelicianoTech merged 1 commit into
wtfutil:trunkfrom
kgehmlich:trunk

Conversation

@kgehmlich

Copy link
Copy Markdown
Contributor

This is a 1-character change that multiplies the timeout setting value by time.Second rather than adding it.

Prior to this fix, if the desired timeout was 30 seconds, a timeout value of 29000000000 had to be supplied (29 x 10^9 nanoseconds + 1 second).


As an aside, I'm absolutely loving this dashboard. Thanks for all the hard work!

This is a 1-character change that multiplies the timeout setting value
by time.Second rather than adding it.

Prior to this fix, if the desired timeout was 30 seconds, a timeout value of
29000000000 had to be supplied (29 x 10^9 nanoseconds + 1 second).

@FelicianoTech FelicianoTech left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch. Thank you for contributing!

@FelicianoTech
FelicianoTech merged commit c6c261e into wtfutil:trunk Sep 29, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ 换网址