Repository navigation
fix: Ctrl+C now exits cleanly via os.Exit(0) - #2140
Merged
Seanstoppable merged 1 commit intoJul 26, 2026
Merged
Conversation
The Ctrl+C handler called TViewApp.Stop() but didn't call os.Exit(0), so background goroutines (widget refresh schedules, config watcher, etc.) kept the process alive. Now uses wtfApp.Exit() which terminates the process, matching the behavior of the 'q' quit key. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Pressing Ctrl+C to exit the app would stop the tview event loop but leave the process hanging. Background goroutines (widget refresh schedules, config file watcher, HTTP calls) kept the process alive indefinitely.
Fix
Replace the inline stop logic in the Ctrl+C handler with a call to
wtfApp.Exit(), which callsos.Exit(0)after cleanup — matching the behavior of theqquit key.