Skip to content

Deprecate glob - #11826

Merged
matthewp merged 1 commit into
nextfrom
deprecate-glob
Aug 27, 2024
Merged

matthewp merged 1 commit into
nextfrom
deprecate-glob

Conversation

@matthewp

Copy link
Copy Markdown
Contributor

Changes

  • Marks Astro.glob as deprecated in the types.
  • Adds a runtime warning when used.

Testing

  • None needed, just a deprecation.
  • Since it's still supported we don't want to actually remove tests yet.

Docs

@changeset-bot

changeset-bot Bot commented Aug 23, 2024 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: e2e6847

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added feat: markdown Related to Markdown (scope) pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope) pkg: example Related to an example package (scope) 🚨 action Modifies GitHub Actions pkg: lit Related to Lit (scope) pkg: integration Related to any renderer integration (scope) pkg: create-astro Related to the `create-astro` package (scope) pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review semver: major Change triggers a `major` release labels Aug 23, 2024

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is blocked because it contains a major changeset. A reviewer will merge this at the next release if approved.

@matthewp
matthewp changed the base branch from main to next August 23, 2024 16:14
This deprecated Astro.glob, see the changeset for details.
@github-actions github-actions Bot removed feat: markdown Related to Markdown (scope) pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope) pkg: example Related to an example package (scope) 🚨 action Modifies GitHub Actions pkg: lit Related to Lit (scope) pkg: integration Related to any renderer integration (scope) pkg: create-astro Related to the `create-astro` package (scope) labels Aug 23, 2024
@matthewp
matthewp merged commit 7315050 into next Aug 27, 2024
@matthewp
matthewp deleted the deprecate-glob branch August 27, 2024 14:51
@Its-Just-Nans

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review semver: major Change triggers a `major` release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

⌂ 换网址