Skip to content

Set external: true when loading astro config - #11819

Merged
bluwy merged 3 commits into
nextfrom
plt-1631-config-external-true
Sep 2, 2024
Merged

bluwy merged 3 commits into
nextfrom
plt-1631-config-external-true

Conversation

@bluwy

@bluwy bluwy commented Aug 22, 2024 •

Copy link
Copy Markdown
Member

Changes

Set external: true when loading the astro config, this means Vite won't process any locally-linked dependencies anymore.

Previously, locally-linked dependencies were automatically "no-externalized", however with external: true, we disable this behaviour, so that all dependencies are "externalized" and hence imported by the nodejs runtime instead.

closes #11621

Testing

Existing tests should pass.

Docs

Added a changeset explaining the change. I don't expect this to be a big breaking change, except potentially for integrations authors or monorepos, they may need to be aware of this change.

@changeset-bot

changeset-bot Bot commented Aug 22, 2024 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: bcb2ab8

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added pkg: astro Related to the core `astro` package (scope) semver: major Change triggers a `major` release labels Aug 22, 2024

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is blocked because it contains a major changeset. A reviewer will merge this at the next release if approved.

@Fryuni Fryuni left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉🎉🎉🎉

This was blocking some magic that I wanted to make but couldn't fix from an integration since it was too late by then.

@bluwy
bluwy dismissed github-actions[bot]’s stale review August 27, 2024 14:57

base branch is next (still awaiting docs review before merging)

@sarah11918 sarah11918 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to be holding you up, @bluwy ! There's just one bit of one sentence that feels like it kind of got away from you. 😄 So just take a peek there and make sure it reads smoothly to you.

A couple of minor tweaks for readability, but good to go!

Comment thread .changeset/moody-waves-think.md Resolved
bluwy and others added 2 commits September 2, 2024 21:01

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is blocked because it contains a major changeset. A reviewer will merge this at the next release if approved.

@bluwy
bluwy merged commit 2bdde80 into next Sep 2, 2024
@bluwy
bluwy deleted the plt-1631-config-external-true branch September 2, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: astro Related to the core `astro` package (scope) semver: major Change triggers a `major` release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

⌂ 换网址