Skip to content

Fix attribute rendering for boolean values (take 2) - #11660

Merged
bluwy merged 8 commits into
nextfrom
plt-2279-render-boolean-values
Aug 13, 2024
Merged

bluwy merged 8 commits into
nextfrom
plt-2279-render-boolean-values

Conversation

@bluwy

@bluwy bluwy commented Aug 9, 2024 •

Copy link
Copy Markdown
Member

Changes

Cherry pick of #11369 (which was reverted as it broke projects)

Testing

Has added tests

Docs

I've updated the changeset with better information of what's changed and how to migrate

@changeset-bot

changeset-bot Bot commented Aug 9, 2024 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 411ceab

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added pkg: integration Related to any renderer integration (scope) pkg: astro Related to the core `astro` package (scope) semver: major Change triggers a `major` release labels Aug 9, 2024

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is blocked because it contains a major changeset. A reviewer will merge this at the next release if approved.

@sarah11918 sarah11918 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was super helpful @bluwy ! Just gave you some suggestions to consider if you want to beef it up a little bit!

Comment thread .changeset/small-ties-sort.md Resolved
Comment thread .changeset/small-ties-sort.md Resolved
Comment thread .changeset/small-ties-sort.md Resolved
Comment thread .changeset/small-ties-sort.md Resolved
Comment thread .changeset/small-ties-sort.md Resolved
bluwy and others added 3 commits August 9, 2024 22:54
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Comment thread .changeset/small-ties-sort.md Resolved

@sarah11918 sarah11918 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with one tiny cut!

@ArmandPhilippot ArmandPhilippot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some suggestions on the changeset because I think there are inconsistencies in attributes between their declaration, rendering and usage (since the renaming).

Comment thread .changeset/small-ties-sort.md Resolved
Comment thread .changeset/small-ties-sort.md Resolved
Comment thread .changeset/small-ties-sort.md Resolved
bluwy and others added 2 commits August 13, 2024 18:25
Co-authored-by: Armand Philippot <59021693+ArmandPhilippot@users.noreply.github.com>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
@bluwy
bluwy merged commit e90f559 into next Aug 13, 2024
@bluwy
bluwy deleted the plt-2279-render-boolean-values branch August 13, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope) semver: major Change triggers a `major` release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

⌂ 换网址