Repository navigation
webnn: rename roundingType to outputShapeRounding for pool2d ops - #59145
Merged
Merged
Conversation
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-7717139
branch
from
April 20, 2026 03:54
928166f to
35f2384
Compare
chromium-wpt-export-bot
marked this pull request as ready for review
April 21, 2026 08:46
This CL renames MLPool2dOptions::roundingType to MLPool2dOptions::outputShapeRounding in test files and implementations according to Spec change [1]. [1] webmachinelearning/webnn#770 Bug: 498118207 Change-Id: I815c7f7728071144835c0ada0747bc9de2999669 Cq-Include-Trybots: luci.chromium.try:mac14.arm64-blink-rel, mac15.arm64-blink-rel, mac15-blink-rel, linux-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7717139 Reviewed-by: Hu, Ningxin <ningxin.hu@intel.com> Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Alex Gough <ajgo@chromium.org> Auto-Submit: Dai, Feng <feng.dai@intel.com> Commit-Queue: Dai, Feng <feng.dai@intel.com> Cr-Commit-Position: refs/heads/main@{#1618021}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-7717139
branch
from
April 21, 2026 08:47
35f2384 to
0bba867
Compare
wpt-pr-bot
approved these changes
Apr 21, 2026
wpt-pr-bot
left a comment
Collaborator
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This CL renames MLPool2dOptions::roundingType to
MLPool2dOptions::outputShapeRounding in test files and implementations
according to Spec change [1].
[1] webmachinelearning/webnn#770
Bug: 498118207
Change-Id: I815c7f7728071144835c0ada0747bc9de2999669
Cq-Include-Trybots: luci.chromium.try:mac14.arm64-blink-rel, mac15.arm64-blink-rel, mac15-blink-rel, linux-blink-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7717139
Reviewed-by: Hu, Ningxin <ningxin.hu@intel.com>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Auto-Submit: Dai, Feng <feng.dai@intel.com>
Commit-Queue: Dai, Feng <feng.dai@intel.com>
Cr-Commit-Position: refs/heads/main@{#1618021}