Skip to content

test: migrate remaining mjs configs to TypeScript - #16354

Merged
chenjiahan merged 1 commit into
mainfrom
chenjiahan/test-mjs-configs-typescript
Oct 30, 2026
Merged

chenjiahan merged 1 commit into
mainfrom
chenjiahan/test-mjs-configs-typescript

Conversation

@chenjiahan

Copy link
Copy Markdown
Member

Motivation

Align the remaining Rspack test configs with the repository's ESM TypeScript convention and include them in config type checking.

Changes

Migrate all 67 remaining rspack.config.mjs files in tests/rspack-test to .ts, adding plugin types and declarations for JavaScript fixture helpers. Preserve existing compatibility cases and skip rules, with localized @ts-expect-error annotations for unsupported APIs.

The JS build and config type check pass. Targeted suites report 86 executed tests passing and 79 existing filtered placeholders.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-30T02:38:11.768681Z 0ab3a9b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown
Contributor

📦 Binary Size-limit

Comparing 0ab3a9b to test(cli): migrate functional configs to ESM TypeScript (#16343) by Jiahan Chen

🙈 Size remains the same at 68.00MB

@github-actions

Copy link
Copy Markdown
Contributor

Rsdoctor Bundle Diff Analysis

Found 5 projects in monorepo, 0 projects with changes.

📊 Quick Summary
Project Total Size Gzip Size Change Gzip Change
popular-libs 1.7 MB 536.0 KB 0 0
react-10k 5.4 MB 1.3 MB 0 0
react-1k 827.5 KB 225.2 KB 0 0
ui-components 4.7 MB 1.4 MB 0 0
react-5k 2.6 MB 670.6 KB 0 0

Generated by Rsdoctor GitHub Action

@chenjiahan
chenjiahan merged commit b1e27d8 into main Oct 30, 2026
44 checks passed
@chenjiahan
chenjiahan deleted the chenjiahan/test-mjs-configs-typescript branch October 30, 2026 02:56
@codspeed

codspeed Bot commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

✅ 57 untouched benchmarks
⏩ 47 skipped benchmarks1


Comparing chenjiahan/test-mjs-configs-typescript (0ab3a9b) with main (8e9b1e6)

Open in CodSpeed

Footnotes

  1. 47 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

⌂ 换网址