Repository navigation
fix(watcher): preserve native event delivery while JavaScript is blocked - #16106
Conversation
Split from #15947; preserves the original patch content.
Deploying rspack with
|
| Latest commit: |
2fa84d5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3bce3b92.rspack-v2.pages.dev |
| Branch Preview URL: | https://codex-15947-1-watcher-delive.rspack-v2.pages.dev |
📦 Binary Size-limit
❌ Size increased by 12.13KB from 67.73MB to 67.75MB (⬆️0.02%) |
Rsdoctor Bundle Diff AnalysisFound 5 projects in monorepo, 0 projects with changes. 📊 Quick Summary
Generated by Rsdoctor GitHub Action |
Merging this PR will not alter performance
Comparing Footnotes
|
|
@ScriptedAlchemy @stormslowly @chenjiahan can we get some movement on this one? I hit this in our apps too and I have a similar fix for it on my fork |
OK, working on it now. |
|
👍 |
Motivation
Native watcher notifications can be dropped while the JavaScript thread is blocked, or delivered to replacement callbacks from a later watch generation.
Changes
Queue raw and aggregate notifications for lossless, ordered delivery and share the binding callback conversion path. Includes the blocked-JavaScript and callback-generation regression from #15947.
Split from the combined implementation in #15947. Layer 1 of 5; merge bottom to top.
Validation
This is a content-preserving split of original head
54a878d2511814fbc2c7d522ebadd1fe37c13301. The final stack tree is byte-for-byte identical to that head, and each layer’s ancestry and patch boundaries were checked. Builds and runtime tests were not rerun for this split; the original combined-PR validation is historical evidence, not a test result for these individual layers. CI must validate each layer.Review notes
The delivery queue is intentionally unbounded while JavaScript is blocked; callback exception and teardown behavior were not separately exercised in the original validation.
Stack
Merge bottom to top; each PR targets the previous layer.