Repository navigation
perf(binding): share NormalModule accessors - #16039
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
📦 Binary Size-limit
❌ Size increased by 4.00KB from 67.25MB to 67.25MB (⬆️0.01%) |
Rsdoctor Bundle Diff AnalysisFound 5 projects in monorepo, 0 projects with changes. 📊 Quick Summary
Generated by Rsdoctor GitHub Action |
Merging this PR will not alter performance
Comparing Footnotes
|
Motivation
Each
NormalModulewrapper creates its ownmatchResourcegetter/setter anderrorgetter, duplicating accessor functions and V8 metadata.Changes
Reuse the existing per-environment shared-descriptor cache for these accessors, preserving own properties, enumeration order and receiver-based behavior. Sharing accessor identities also lets V8 use compact property storage instead of per-instance dictionaries.
The pre-rebase Share landing A/B (full client + server, production, minification off, cache enabled) measured:
This is live V8 memory savings; a stable peak-RSS reduction was not established.