Skip to content

chore(ci): pause portable cache check - #14492

Merged
stormslowly merged 1 commit into
mainfrom
codex/pause-portable-cache-job
Jun 19, 2026
Merged

stormslowly merged 1 commit into
mainfrom
codex/pause-portable-cache-job

Conversation

@stormslowly

Copy link
Copy Markdown
Contributor

Summary

  • pause the portable cache comparison job until portable cache support is implemented
  • move the existing TODO above the job so the disabled state is explicit
  • update the required-check expectations to accept the skipped job on pull requests and main pushes
  • keep the real comparison command ready for re-enabling the job

Why

The job currently allocates a runner, downloads Linux and Windows cache artifacts, and installs Rust, but only executes a placeholder success command. Pausing it avoids that resource usage without removing the future portable-cache validation flow.

Validation

  • git diff --check
  • parsed .github/workflows/ci.yml with Ruby YAML
  • verified the expected needs.*.result sequences for pull requests and main pushes

actionlint was not run because it is not installed locally.

@github-actions

Copy link
Copy Markdown
Contributor

📦 Binary Size-limit

Comparing ee4d5a2 to chore: remove codspeed js bench case (#14489) by Cong-Cong Pan

🙈 Size remains the same at 67.93MB

@stormslowly
stormslowly marked this pull request as ready for review June 18, 2026 09:06
Copilot AI review requested due to automatic review settings June 18, 2026 09:06

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the main CI workflow to temporarily pause the “portable cache” comparison job (which currently does non-useful work) while preserving the intended comparison command for re-enabling later, and adjusts the required-check aggregator logic to treat that job as skipped.

Changes:

  • Disable the check-cache job via a constant-false if: condition and move the TODO to make the disabled status explicit.
  • Replace the placeholder “success” command in check-cache with the real rspack_tools compare command (ready for when the job is re-enabled).
  • Update test_required_check’s expected needs.*.result sequences to accept check-cache as skipped for PRs and non-PR runs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codspeed

codspeed Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

✅ 41 untouched benchmarks
⏩ 47 skipped benchmarks1


Comparing codex/pause-portable-cache-job (ee4d5a2) with main (dc33a0f)

Open in CodSpeed

Footnotes

  1. 47 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@stormslowly
stormslowly enabled auto-merge (squash) June 18, 2026 09:23
@stormslowly
stormslowly merged commit 5b9e15b into main Jun 19, 2026
37 checks passed
@stormslowly
stormslowly deleted the codex/pause-portable-cache-job branch June 19, 2026 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

⌂ 换网址