Repository navigation
chore(ci): pause portable cache check - #14492
Conversation
📦 Binary Size-limit
🙈 Size remains the same at 67.93MB |
There was a problem hiding this comment.
Pull request overview
This PR updates the main CI workflow to temporarily pause the “portable cache” comparison job (which currently does non-useful work) while preserving the intended comparison command for re-enabling later, and adjusts the required-check aggregator logic to treat that job as skipped.
Changes:
- Disable the
check-cachejob via a constant-falseif:condition and move the TODO to make the disabled status explicit. - Replace the placeholder “success” command in
check-cachewith the realrspack_tools comparecommand (ready for when the job is re-enabled). - Update
test_required_check’s expectedneeds.*.resultsequences to acceptcheck-cacheasskippedfor PRs and non-PR runs.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Merging this PR will not alter performance
Comparing Footnotes
|
Summary
Why
The job currently allocates a runner, downloads Linux and Windows cache artifacts, and installs Rust, but only executes a placeholder success command. Pausing it avoids that resource usage without removing the future portable-cache validation flow.
Validation
git diff --check.github/workflows/ci.ymlwith Ruby YAMLneeds.*.resultsequences for pull requests and main pushesactionlintwas not run because it is not installed locally.