Skip to content

perf(loader-runner): reduce loader object construction overhead - #14477

Merged
hardfist merged 1 commit into
mainfrom
chenjiahan/reduce-loader-object-overhead
Jun 18, 2026
Merged

hardfist merged 1 commit into
mainfrom
chenjiahan/reduce-loader-object-overhead

Conversation

@chenjiahan

@chenjiahan chenjiahan commented Jun 17, 2026 •

Copy link
Copy Markdown
Member

Summary

This PR reduces loader-runner overhead on the hot runLoaders path by removing the temporary createLoaderObject shape.

Performance data from benchmark:

  • LoaderObject constructor self time median: 133.836 ms -> 67.085 ms (-49.9%)
  • Removed request accessor getter/setter self time median: 59.127 ms -> 0 ms
  • Combined targeted self time: 192.794 ms -> 65.874 ms (-65.8%)

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@chenjiahan
chenjiahan marked this pull request as ready for review June 17, 2026 14:38
@chenjiahan
chenjiahan requested a review from hardfist as a code owner June 17, 2026 14:38
@github-actions

Copy link
Copy Markdown
Contributor

📦 Binary Size-limit

Comparing 1e76247 to fix(rstest): preserve mocks in module chunk loading (#14472) by 9aoy

🙈 Size remains the same at 67.93MB

@codspeed

codspeed Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

✅ 50 untouched benchmarks
⏩ 38 skipped benchmarks1


Comparing chenjiahan/reduce-loader-object-overhead (1e76247) with main (17e99c3)

Open in CodSpeed

Footnotes

  1. 38 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@hardfist
hardfist merged commit c87244f into main Jun 18, 2026
54 of 58 checks passed
@hardfist
hardfist deleted the chenjiahan/reduce-loader-object-overhead branch June 18, 2026 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ 换网址