Skip to content

fix(core): check path boundaries in lazy compilation logs - #8550

Merged
chenjiahan merged 1 commit into
mainfrom
chenjiahan/fix-lazy-compilation-log-paths
Sep 26, 2026
Merged

chenjiahan merged 1 commit into
mainfrom
chenjiahan/fix-lazy-compilation-log-paths

Conversation

@chenjiahan

Copy link
Copy Markdown
Member

Motivation

Lazy compilation logs treat sibling paths sharing the project root prefix as project files. For example, a root of /repo/app turns /repo/app-shared/src/index.js into the misleading log path -shared/src/index.js.

Changes

Include the trailing path separator when matching the project root and slice off the matched prefix. This keeps sibling paths out of the project-relative log entries.

Validated with pnpm build, lazy-compilation e2e tests, and lint/type and formatting checks.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-26T03:40:07.798157Z 2c72dc9 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chenjiahan
chenjiahan merged commit 6a8ddd4 into main Sep 26, 2026
7 checks passed
@chenjiahan
chenjiahan deleted the chenjiahan/fix-lazy-compilation-log-paths branch September 26, 2026 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

⌂ 换网址