Skip to content

perf(core): statically import util and zlib in server helpers - #8523

Merged
chenjiahan merged 1 commit into
mainfrom
chenjiahan/perf-static-util-zlib-imports
Sep 22, 2026
Merged

chenjiahan merged 1 commit into
mainfrom
chenjiahan/perf-static-util-zlib-imports

Conversation

@chenjiahan

Copy link
Copy Markdown
Member

Motivation

Browser opening dynamically imports node:util, although core's formatting helpers already import it statically. Preview compression likewise dynamically imports node:zlib, which its gzip middleware already imports statically, so neither import provides a lazy-loading benefit.

Changes

Statically import promisify and the zlib constants to avoid redundant dynamic import resolution and Promise overhead.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-22T09:29:31.275973Z 89c6857 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chenjiahan
chenjiahan merged commit 550129f into main Sep 22, 2026
7 checks passed
@chenjiahan
chenjiahan deleted the chenjiahan/perf-static-util-zlib-imports branch September 22, 2026 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

⌂ 换网址