Undefined entities are not reported for EPUB2 checks. #1546

Activity

1. rdeltour commented on Oct 13, 2023

   

   rdeltour

   on Oct 13, 2023

   Member

   More actions

   If entities are defined in an external DTD, that would be valid in EPUB 2 (but not in EPUB 3).
   Could you share a sample file to reproduce the issue?
2. rdeltour

   self-assigned this

   on Oct 13, 2023
3. rdeltour

   added

   status: waiting for feedbackThe development team needs feedback from the issue’s creatorThe development team needs feedback from the issue’s creator

   type: unverifiedThe issue couldn't be reproducedThe issue couldn't be reproduced

   on Oct 13, 2023
4. typopaul commented on Nov 2, 2023

   

   typopaul

   on Nov 2, 2023

   Author

   More actions

   @rdeltour

   Find attached a zip file with a sample file containing a "wrong" entity in an EPUB2 file and a screenshot from the Thorium Reader.
   I understand that the entity should be associated with an external DTD/resource.
   I am surprised that the EPUB Checker does not report it as an error but Thorium Reader does.

   issue1546_sample-entity-error-EPUB2.zip
5. rdeltour

   added this to the Next maintenance release milestone on Dec 18, 2023
6. rdeltour

   added

   status: in progressThe issue is being implemented by the development teamThe issue is being implemented by the development team

   type: false-negativeThis issue is about invalid content being incorrectly acceptedThis issue is about invalid content being incorrectly accepted

   and removed

   status: waiting for feedbackThe development team needs feedback from the issue’s creatorThe development team needs feedback from the issue’s creator

   type: unverifiedThe issue couldn't be reproducedThe issue couldn't be reproduced

   on Dec 20, 2024
7. rdeltour

   added a commit that references this issue on Dec 23, 2024

   fix: report undefined entity references in EPUB 2.0.1

   ...

   This issue will close once commit 4ad738c is merged into the 'main' branch.

   4ad738c
8. rdeltour

   added

   status: has PRThe issue is being processed in a pull requestThe issue is being processed in a pull request

   and removed

   status: in progressThe issue is being implemented by the development teamThe issue is being implemented by the development team

   on Dec 23, 2024
9. rdeltour

   closed this as completedin 4ad738con Dec 23, 2024