Skip to content

Properties removed from the link vocabulary #1457

Closed

Description

@mattgarrish

As we found no evidence of xmp records being used, there was no case for keeping the xmp properties value as under-implemented, or even keeping it as deprecated (only the onix property is used). It should be safe to remove this from validation.

The acquire rel value was also removed from the vocabulary, but it should be left valid because it was defined in the Previews spec. I think we have some partial validation support for previews, but it's probably not worth the effort of making it valid only in those types of publications - just leave it as an acceptable rel value.

See w3c/epub-specs#2489

Activity

  1. mattgarrish commented on Dec 9, 2022

    @mattgarrish
    MemberAuthor

    Note that if acquire remains valid, the test for it in the test suite should be untagged: https://github.com/w3c/epubcheck/blob/main/src/test/resources/epub3/D-vocabularies/metadata-link.feature#L18

    This will no longer be part of the report.

    Running a search on the epub3 feature folder the only test that needs updating to remove an xmp link is here: https://github.com/w3c/epubcheck/blob/main/src/test/resources/epub3/D-vocabularies/files/link-rel-record-properties-valid.opf#L10

    That line can be removed without having to change anything else, as it has an onix link that remains valid.

  2. self-assigned this
    on Dec 15, 2022
  3. added this to the v5.0.0-rc milestone on Dec 15, 2022
  4. added a commit that references this issue on Dec 23, 2022
    ab13ef0
  5. added
    status: has PRThe issue is being processed in a pull request
    and removed on Dec 23, 2022
  6. added a commit that references this issue on Jan 3, 2023
    6a3d2a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

status: has PRThe issue is being processed in a pull requesttype: specThe issue is related to a Specification update

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

    ⌂ 换网址