Skip to content

Check data-* name restrictions #1107

New issue
New issue
Closed
#1469
Closed
Check data-* name restrictions#1107
#1469
Assignees
rdeltour
Labels
spec: EPUB 3.xImpacting the support of EPUB 3.x specificationsstatus: has PRThe issue is being processed in a pull requesttype: improvementThe issue suggests an improvement of an existing feature
Milestone
v5.0.0-rc

Description

@mattgarrish
mattgarrish
opened on Mar 12, 2020

I noticed that we check that data-* attributes are allowed in both XHTML and SVG content documents but we don't appear to be enforcing the naming restrictions in the HTML specification -- specifically that the name can't begin with "xml" or contain upper-ascii characters.

https://html.spec.whatwg.org/multipage/dom.html#embedding-custom-non-visible-data-with-the-data-*-attributes

Activity

  1. rdeltour
    added
    spec: EPUB 3.xImpacting the support of EPUB 3.x specifications
    status: in discussionThe issue is being discussed by the development team
    type: improvementThe issue suggests an improvement of an existing feature
    on Mar 12, 2020
  2. rdeltour
    added this to the v5.0.0-rc milestone on Dec 8, 2022
  3. rdeltour
    self-assigned this
    on Dec 8, 2022
  4. rdeltour
    added
    status: ready for implemThe issue is ready to be implemented
    and removed
    status: in discussionThe issue is being discussed by the development team
    on Dec 8, 2022
  5. rdeltour
    added a commit that references this issue on Dec 23, 2022

    feat: check "data-*" attributes name restrictions

    aa75f9b

  6. rdeltour commented on Dec 23, 2022

    @rdeltour
    rdeltour
    on Dec 23, 2022
    Member

    This should be ideally delegated to validator.nu, but I added a new check for it until we fully integrate the HTML checker.

    I don't think validator.nu fully implements the rules btw (it does not complain if the attribute contains upper alphas). But in any case, I don't expect this check to report much new errors with existing content… we'll see!

  7. rdeltour
    added
    status: has PRThe issue is being processed in a pull request
    and removed
    status: ready for implemThe issue is ready to be implemented
    on Dec 23, 2022
  8. rdeltour
    added a commit that references this issue on Jan 3, 2023

    feat: check "data-*" attributes name restrictions

    22f5994
  9. rdeltour
    closed this as completedin 22f5994on Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

spec: EPUB 3.xImpacting the support of EPUB 3.x specificationsstatus: has PRThe issue is being processed in a pull requesttype: improvementThe issue suggests an improvement of an existing feature

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions
    ⌂ 换网址