Skip to content

Remove deprecated ioutil from generator - #367

Merged
wmatveyenko merged 1 commit into
twitchtv:mainfrom
marwan-at-work:marwan/rmioutil
Sep 19, 2022
Merged

wmatveyenko merged 1 commit into
twitchtv:mainfrom
marwan-at-work:marwan/rmioutil

Conversation

@marwan-at-work

Copy link
Copy Markdown
Contributor

The ioutil std lib package has been deprecated for a few releases now, this PR removes all references to them.

@marioizquierdo

marioizquierdo commented Sep 16, 2022 •

Copy link
Copy Markdown
Contributor

What is the latest version of Go that would not work with this change? I seems that io.ReadAll was introduced in Go 1.16, meaning that this change would not work with Go 1.15 and below. Since the current version is 1.19 and Twirp promises to keep compatibility with the last 2 versions, the change seems fine. Can we confirm this?

@marwan-at-work

Copy link
Copy Markdown
Contributor Author

@marioizquierdo Yes, the docs on the ioutil package say 1.16 as well https://pkg.go.dev/io/ioutil

@wmatveyenko

Copy link
Copy Markdown
Contributor

Thank for your contribution. Can you add -

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@marwan-at-work

Copy link
Copy Markdown
Contributor Author

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@wmatveyenko
wmatveyenko merged commit bc07165 into twitchtv:main Sep 19, 2022
@wmatveyenko

Copy link
Copy Markdown
Contributor

Thanks for your contribution.

@marwan-at-work

Copy link
Copy Markdown
Contributor Author

@wmatveyenko thank you (and to the others) for keeping the project maintained. Let me know if you plan on cutting a patch release. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

⌂ 换网址