Skip to content

PR checks: add with clientcompact tests - #321

Merged
marioizquierdo merged 18 commits into
mainfrom
run_clientcompat_tests_as_pr_check
Jun 12, 2021
Merged

marioizquierdo merged 18 commits into
mainfrom
run_clientcompat_tests_as_pr_check

Conversation

@marioizquierdo

@marioizquierdo marioizquierdo commented Jun 12, 2021 •

Copy link
Copy Markdown
Contributor

Fixes #315

Update the Github workflow used to verify pull requests.

Specific changes:

  • Add clientcompact tests to commit check
  • Remove coverage checks. The coverage was for 12% only, but that is because most of the code in the package is auto-generated code. Coverage is not significant for Twirp, because the generator is indirectly tested through the generated files. Twirp reviewers need to manually check that tests are properly covering use-cases anyways.
  • Remove pr-checks, keep only commit push checks: because the only difference was the coverage.
  • Cleanup Makefile
  • Re-generate code with newer protoc compiler

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@marioizquierdo
marioizquierdo merged commit 7a31131 into main Jun 12, 2021
@marioizquierdo
marioizquierdo deleted the run_clientcompat_tests_as_pr_check branch June 12, 2021 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix clientcompat and include tests on CI build

1 participant

⌂ 换网址