Skip to content

Fix clientcompat for APIV2 - #313

Merged
marioizquierdo merged 1 commit into
twitchtv:masterfrom
timostamm:master
May 18, 2021
Merged

marioizquierdo merged 1 commit into
twitchtv:masterfrom
timostamm:master

Conversation

@timostamm

Copy link
Copy Markdown
Contributor

reflect.DeepEqual() does not work as expected anymore with APIV2, see #310 for details.
Using proto.Equal() instead.

fixes #310

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

reflect.DeepEqual() does not work as expected anymore with APIV2.
Using proto.Equal() instead.

fixes twitchtv#310
@marioizquierdo
marioizquierdo merged commit f3251e3 into twitchtv:master May 18, 2021
@marioizquierdo

Copy link
Copy Markdown
Contributor

LGTM, thank you for the fix!
I can merge it in the main branch right away, and will tag it along with the next release soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

clientcompat issue with V8

2 participants

⌂ 换网址