Skip to content

Update context from callError - #268

Merged
marioizquierdo merged 1 commit into
twitchtv:masterfrom
mickeyreiss:fix-call-error-context
Sep 13, 2020
Merged

marioizquierdo merged 1 commit into
twitchtv:masterfrom
mickeyreiss:fix-call-error-context

Conversation

@mickeyreiss

Copy link
Copy Markdown
Contributor

Assuming #267 is an valid bug report, this PR provides a fix to protoc-gen-twirp, so that the context returned by Error server hooks (on write errors) is subsequently passed into ResponseSent.

Fixes #267.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@marioizquierdo

Copy link
Copy Markdown
Contributor

Looks good to me. We should include this on the next release, thanks!

@mickeyreiss

Copy link
Copy Markdown
Contributor Author

@marioizquierdo Is there anything left to do on my end, in order to get this landed?

@marioizquierdo

Copy link
Copy Markdown
Contributor

Nah, you are good. I will help get this merged sometime this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ServerHooks Context bug: Context from Error is not passed to ResponseSent

2 participants

⌂ 换网址