Repository navigation
Conversation
arshamalh
added a commit
to arshamalh/tbb
that referenced
this pull request
Oct 12, 2026
Bot.Download always writes to a local path. A bot that only relays a file (to object storage, another service, a model) had to write it to disk and read it back. DownloadToWriter streams the file straight into any io.Writer. Brought over from tucnak/telebot#704, which was never merged upstream, and tested against a fake file server.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case of
(b *Bot) Download(file *File, localFilename string) errorfunction, users may need different actions than just saving the file automatically on disk, e.g.Having another DownloadToWriter method that accepts any kind of
io.Writerwill help users skip an extra step to save on disk and read from the disk.