Repository navigation
fix: avoid oneOf when @Accept adds default schema - #2131
Merged
Merged
Conversation
taba2424
marked this pull request as ready for review
January 10, 2026 20:51
|
It would be great to have it. I was really confused when I discovered this |
kundkingan
approved these changes
Apr 9, 2026
Contributor
|
@taba2424 Thanks for your contribution. |
|
When can we expect a new rc release @ubogdan |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the PR
@Acceptdoes not get merged viaoneOfwith the actual body schema.type: objectwith the real body schema when@Param ... bodyis parsed after@Accept.@Accept json+ body parameter.Relation issue
N/A (no related issue)
Additional context
Example setup:
Command (example):
Generated specs using swag init with OpenAPI v3.1 output and YAML format.
Before, the generated requestBody schema included:
This PR ensures the placeholder type: object from @accept is replaced by the actual body schema, resulting in only the $ref entry.