Repository navigation
Fixes list recursion - #2022
Merged
Merged
Fixes list recursion#2022
Conversation
Author
|
Just some validation of the tests I wrote. Prior to either of my fix commits, the test fails with this: And with the first fix applied it fails with this: As can be seen in CI, both fixes make the tests pass |
Contributor
|
Please rebase and fix conflicts. |
I had 2 issues. 1) A panic due to nil pointer when p.openAPI.Components.Spec.Schemas[searchString] was nil, and getSchemaByRef tried to return .Spec Resolved with a simple check and nill return (to start) This highlighted issue 2 which in some ways relates to swaggo#1939 2) When an ARRAY schema type is evaluated, and getSchemaByRef returns nil, generation would fail. So getSchemaByRef is changed to warn and return ANY instead similar to some other places, which means the generation can work. I expect this could be resolved more globally at some point pulling in other things from the linked issue...
Prior to this, in cases where recursion was detected, the annotated @name value was not used in the generated spec. This in turn would lead to invalid spec, as some values would be using the full name, and others the hort name...
addshore
force-pushed
the
v2-addshore-fix-list-recursion
branch
from
August 18, 2025 10:25
1186089 to
256e493
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had 3 issues.
p.openAPI.Components.Spec.Schemas[searchString]
was nil, and getSchemaByRef tried to return .Spec
Resolved with a simple check and nill return (to start)
This highlighted issue 2 which in some ways relates to #1939
So getSchemaByRef is changed to warn and return ANY instead similar to some other places, which means the generation can work.
A few weeks passed and I fonud another issue
I expect this could be resolved more globally at some point pulling in other things from the linked issue...