Repository navigation
Fix Response Schema Handling with Custom MIME Types - #2019
Merged
Merged
Conversation
Contributor
|
@fosple please fix conflicts. |
Author
|
@ubogdan done |
ubogdan
approved these changes
Sep 11, 2025
Contributor
|
@fosple Thanks for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where response schemas weren't properly associated with custom MIME types. In the original code it was marked with a TODO. When using @produce with a custom MIME type (like json-api), schema references weren't being correctly linked to those MIME types in the OpenAPI spec output.
Changes:
The changes ensure that when you specify
@Produce json-apifollowed by a response schema via@Success, the schema is correctly linked to theapplication/vnd.api+jsonMIME type in the OpenAPI document, rather than being linked to the defaultapplication/jsontype.This fixes issues when generated clients need to consume non-standard response content types.