Skip to content

fix: segmentation error when using Slice as a type for generic (Wrapper[[]T]) in -v3.1 - #1997

Merged
sdghchj merged 1 commit into
swaggo:v2from
OnFireByte:fix-generic-of-slice-nil-error
Sep 23, 2025
Merged

sdghchj merged 1 commit into
swaggo:v2from
OnFireByte:fix-generic-of-slice-nil-error

Conversation

@OnFireByte

Copy link
Copy Markdown

Describe the PR
As described in the issue, mainly adding File field and value to TypeSpecDef in the getTypeFromGenericParam function in case that genericParam is slice or map.

Relation issue
#1935

@abrar71

abrar71 commented Jul 20, 2025

Copy link
Copy Markdown

I've tested this pull request and its imperative to be merged asap to resolve issue #1935

Thank you!

@ubogdan

ubogdan commented Sep 11, 2025

Copy link
Copy Markdown
Contributor

@abrar71 First condition to start reviewing the PR is the pipeline to succed.

@OnFireByte
OnFireByte force-pushed the fix-generic-of-slice-nil-error branch from 91f8ded to 7e09db4 Compare September 18, 2025 17:16
@OnFireByte

OnFireByte commented Sep 18, 2025 •

Copy link
Copy Markdown
Author

Hi, the failed pipeline seemed to come from the old merged PR itself, so I didn't take any action after. It should probably be ok now; quick make test seems to be ok too.

@sdghchj
sdghchj merged commit bc4b08e into swaggo:v2 Sep 23, 2025
@OnFireByte
OnFireByte deleted the fix-generic-of-slice-nil-error branch September 24, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

⌂ 换网址