Repository navigation
Feat openapiv3 oneof - #1870
Merged
Merged
Feat openapiv3 oneof#1870
Conversation
Contributor
|
Please rebase from V2, we updated the go version and it's very likely to work now. |
kkkiio
force-pushed
the
feat-openapiv3-oneof
branch
from
October 21, 2024 14:28
6cc8177 to
2fa63cf
Compare
|
Thank you very much for your contribution. However, currently only response is supported. It is hoped that oneof will also be supported for https://swagger.io/docs/specification/v3_0/data-models/oneof-anyof-allof-not/ |
|
This seems to introduce a new issue to all request bodies, making them oneOf regardless of what input they have // @Summary Restore a configuration rule from history
// @Description Restores a previous version of a rule based on a history ID. This creates a new rule with the old value.
// @Tags Secret
// @Accept json
// @Produce json
// @Param historyID path string true "ID of the history entry to restore"
// @Param restore body restoreRuleRequest true "Restore rule payload"
// @Success 201 {object} ruleResponse requestBody:
content:
application/json:
schema:
oneOf:
- type: object # This should not be
- $ref: '#/components/schemas/secret.restoreRuleRequest'
description: Restore rule payload
summary: restoreI think it is getting confused with the Should I create a new issue about this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the PR
Adds support for the oneOf feature in OpenAPI v3, allowing you to describe a field/response that can have multiple types.
Relation issue
#1363
#1617
Additional context
Unfortunately, the PR #1671 was reverted due to a compile error caused by the use of the
mapspackage.The
mapspackage was introduced in Go 1.21, but the project is currently using Go 1.18.