Skip to content

builders - #81

Merged
SVilgelm merged 1 commit into
mainfrom
builders
Dec 17, 2024
Merged

SVilgelm merged 1 commit into
mainfrom
builders

Conversation

@SVilgelm

Copy link
Copy Markdown
Member

No description provided.

@SVilgelm
SVilgelm requested a review from Copilot December 14, 2024 22:03

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 17 out of 32 changed files in this pull request and generated no comments.

Files not reviewed (15)
  • media_type.go: Evaluated as low risk
  • license.go: Evaluated as low risk
  • info.go: Evaluated as low risk
  • extensions_test.go: Evaluated as low risk
  • components_test.go: Evaluated as low risk
  • callback.go: Evaluated as low risk
  • oauth-flow.go: Evaluated as low risk
  • encoding.go: Evaluated as low risk
  • discriminator.go: Evaluated as low risk
  • oauth-flows.go: Evaluated as low risk
  • contact.go: Evaluated as low risk
  • link.go: Evaluated as low risk
  • external-docs.go: Evaluated as low risk
  • example.go: Evaluated as low risk
  • components.go: Evaluated as low risk
Comments suppressed due to low confidence (1)

extensions.go:47

  • [nitpick] The function name 'Add' might be ambiguous. Consider renaming it to 'AddExt' to clearly indicate its purpose.
func (o *Extendable[T]) Add(name string, value any) *Extendable[T] {

@SVilgelm
SVilgelm force-pushed the builders branch 2 times, most recently from 7ff9d70 to 6d25706 Compare December 15, 2024 05:44
@SVilgelm
SVilgelm requested a review from Copilot December 15, 2024 05:45

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 23 out of 38 changed files in this pull request and generated 2 comments.

Files not reviewed (15)
  • callback.go: Evaluated as low risk
  • media_type.go: Evaluated as low risk
  • bool_or_schema.go: Evaluated as low risk
  • components_test.go: Evaluated as low risk
  • extensions_test.go: Evaluated as low risk
  • oauth-flow.go: Evaluated as low risk
  • components.go: Evaluated as low risk
  • example.go: Evaluated as low risk
  • external-docs.go: Evaluated as low risk
  • contact.go: Evaluated as low risk
  • encoding.go: Evaluated as low risk
  • license.go: Evaluated as low risk
  • discriminator.go: Evaluated as low risk
  • oauth-flows.go: Evaluated as low risk
  • extensions.go: Evaluated as low risk
Comments suppressed due to low confidence (3)

info.go:82

  • The receiver name 'o' should be 'b' to be consistent with the rest of the methods in the InfoBuilder.
func (o *InfoBuilder) AddExt(name string, value any) *InfoBuilder {

info.go:82

  • [nitpick] The method name 'AddExt' is inconsistent with other builder methods. It should be renamed to 'AddExtension' for consistency.
func (o *InfoBuilder) AddExt(name string, value any) *InfoBuilder {

operation.go:233

  • [nitpick] The method name 'AddParameters' should be renamed to 'AddParameter' for consistency with other similar methods.
func (b *OperationBuilder) AddParameters(v ...*RefOrSpec[Extendable[Parameter]]) *OperationBuilder {

Comment thread openapi.go Resolved
Comment thread openapi.go Resolved

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 23 out of 38 changed files in this pull request and generated no comments.

Files not reviewed (15)
  • info.go: Evaluated as low risk
  • extensions_test.go: Evaluated as low risk
  • license.go: Evaluated as low risk
  • components_test.go: Evaluated as low risk
  • callback.go: Evaluated as low risk
  • oauth-flow.go: Evaluated as low risk
  • components.go: Evaluated as low risk
  • example.go: Evaluated as low risk
  • encoding.go: Evaluated as low risk
  • discriminator.go: Evaluated as low risk
  • contact.go: Evaluated as low risk
  • external-docs.go: Evaluated as low risk
  • oauth-flows.go: Evaluated as low risk
  • link.go: Evaluated as low risk
  • bool_or_schema.go: Evaluated as low risk
Comments suppressed due to low confidence (2)

openapi.go:193

  • [nitpick] The method name 'AddComponent' is ambiguous. It should be renamed to 'AddSchemaComponent' or something more descriptive.
func (b *OpenAPIBuilder) AddComponent(name string, component any) *OpenAPIBuilder {

openapi.go:226

  • The function 'NewWebhooks()' is not provided in the diff. Ensure that this function exists and works as intended.
b.spec.Spec.WebHooks = NewWebhooks()

@SVilgelm
SVilgelm merged commit 0a8311c into main Dec 17, 2024
@SVilgelm
SVilgelm deleted the builders branch December 17, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ 换网址