Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 17 out of 32 changed files in this pull request and generated no comments.
Files not reviewed (15)
- media_type.go: Evaluated as low risk
- license.go: Evaluated as low risk
- info.go: Evaluated as low risk
- extensions_test.go: Evaluated as low risk
- components_test.go: Evaluated as low risk
- callback.go: Evaluated as low risk
- oauth-flow.go: Evaluated as low risk
- encoding.go: Evaluated as low risk
- discriminator.go: Evaluated as low risk
- oauth-flows.go: Evaluated as low risk
- contact.go: Evaluated as low risk
- link.go: Evaluated as low risk
- external-docs.go: Evaluated as low risk
- example.go: Evaluated as low risk
- components.go: Evaluated as low risk
Comments suppressed due to low confidence (1)
extensions.go:47
- [nitpick] The function name 'Add' might be ambiguous. Consider renaming it to 'AddExt' to clearly indicate its purpose.
func (o *Extendable[T]) Add(name string, value any) *Extendable[T] {
SVilgelm
force-pushed
the
builders
branch
2 times, most recently
from
December 15, 2024 05:44
7ff9d70 to
6d25706
Compare
Contributor
There was a problem hiding this comment.
Copilot reviewed 23 out of 38 changed files in this pull request and generated 2 comments.
Files not reviewed (15)
- callback.go: Evaluated as low risk
- media_type.go: Evaluated as low risk
- bool_or_schema.go: Evaluated as low risk
- components_test.go: Evaluated as low risk
- extensions_test.go: Evaluated as low risk
- oauth-flow.go: Evaluated as low risk
- components.go: Evaluated as low risk
- example.go: Evaluated as low risk
- external-docs.go: Evaluated as low risk
- contact.go: Evaluated as low risk
- encoding.go: Evaluated as low risk
- license.go: Evaluated as low risk
- discriminator.go: Evaluated as low risk
- oauth-flows.go: Evaluated as low risk
- extensions.go: Evaluated as low risk
Comments suppressed due to low confidence (3)
info.go:82
- The receiver name 'o' should be 'b' to be consistent with the rest of the methods in the InfoBuilder.
func (o *InfoBuilder) AddExt(name string, value any) *InfoBuilder {
info.go:82
- [nitpick] The method name 'AddExt' is inconsistent with other builder methods. It should be renamed to 'AddExtension' for consistency.
func (o *InfoBuilder) AddExt(name string, value any) *InfoBuilder {
operation.go:233
- [nitpick] The method name 'AddParameters' should be renamed to 'AddParameter' for consistency with other similar methods.
func (b *OperationBuilder) AddParameters(v ...*RefOrSpec[Extendable[Parameter]]) *OperationBuilder {
Contributor
There was a problem hiding this comment.
Copilot reviewed 23 out of 38 changed files in this pull request and generated no comments.
Files not reviewed (15)
- info.go: Evaluated as low risk
- extensions_test.go: Evaluated as low risk
- license.go: Evaluated as low risk
- components_test.go: Evaluated as low risk
- callback.go: Evaluated as low risk
- oauth-flow.go: Evaluated as low risk
- components.go: Evaluated as low risk
- example.go: Evaluated as low risk
- encoding.go: Evaluated as low risk
- discriminator.go: Evaluated as low risk
- contact.go: Evaluated as low risk
- external-docs.go: Evaluated as low risk
- oauth-flows.go: Evaluated as low risk
- link.go: Evaluated as low risk
- bool_or_schema.go: Evaluated as low risk
Comments suppressed due to low confidence (2)
openapi.go:193
- [nitpick] The method name 'AddComponent' is ambiguous. It should be renamed to 'AddSchemaComponent' or something more descriptive.
func (b *OpenAPIBuilder) AddComponent(name string, component any) *OpenAPIBuilder {
openapi.go:226
- The function 'NewWebhooks()' is not provided in the diff. Ensure that this function exists and works as intended.
b.spec.Spec.WebHooks = NewWebhooks()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.