Repository navigation
validate examples - #79
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 16 out of 31 changed files in this pull request and generated no comments.
Files not reviewed (15)
- components.go: Evaluated as low risk
- example.go: Evaluated as low risk
- callback.go: Evaluated as low risk
- extensions.go: Evaluated as low risk
- path_item.go: Evaluated as low risk
- encoding.go: Evaluated as low risk
- ref.go: Evaluated as low risk
- oauth-flows.go: Evaluated as low risk
- license.go: Evaluated as low risk
- contact.go: Evaluated as low risk
- media_type.go: Evaluated as low risk
- header.go: Evaluated as low risk
- link.go: Evaluated as low risk
- info.go: Evaluated as low risk
- external-docs.go: Evaluated as low risk
Comments suppressed due to low confidence (3)
parameter.go:180
- [nitpick] Consider renaming the variable 'loc' to 'location' for improved readability.
func (o *Parameter) validateSpec(loc string, opts *specValidationOptions) []*validationError {
parameter.go:206
- [nitpick] The error message for 'style' could be more descriptive. Consider changing it to 'Invalid value for 'style'. Expected one of [%s, %s, %s, %s], but got '%s''.
errs = append(errs, newValidationError(joinLoc(loc, "style"), "must be one of [%s, %s, %s, %s], but got '%s'", StyleMatrix, StyleLabel, StyleForm, StyleSimple, o.Style))
parameter.go:191
- [nitpick] The error message for 'content' could be more descriptive. Consider changing it to 'Invalid number of items for 'content'. Expected only one item, but got '%d''.
errs = append(errs, newValidationError(joinLoc(loc, "content"), "must be only one item, but got '%d'", l))
SVilgelm
force-pushed
the
examples-validation
branch
from
December 13, 2024 06:36
c55c91b to
7e7370f
Compare
SVilgelm
force-pushed
the
examples-validation
branch
from
December 13, 2024 13:50
7e7370f to
44ff6b4
Compare
Contributor
There was a problem hiding this comment.
Copilot reviewed 17 out of 32 changed files in this pull request and generated 1 comment.
Files not reviewed (15)
- example.go: Evaluated as low risk
- components.go: Evaluated as low risk
- encoding.go: Evaluated as low risk
- path_item.go: Evaluated as low risk
- extensions.go: Evaluated as low risk
- oauth-flows.go: Evaluated as low risk
- license.go: Evaluated as low risk
- header.go: Evaluated as low risk
- callback.go: Evaluated as low risk
- link.go: Evaluated as low risk
- info.go: Evaluated as low risk
- contact.go: Evaluated as low risk
- discriminator.go: Evaluated as low risk
- external-docs.go: Evaluated as low risk
- paths.go: Evaluated as low risk
SVilgelm
force-pushed
the
examples-validation
branch
from
December 13, 2024 14:02
5bb9300 to
2d0e326
Compare
Contributor
There was a problem hiding this comment.
Copilot reviewed 17 out of 32 changed files in this pull request and generated no comments.
Files not reviewed (15)
- external-docs.go: Evaluated as low risk
- link.go: Evaluated as low risk
- license.go: Evaluated as low risk
- info.go: Evaluated as low risk
- header.go: Evaluated as low risk
- example.go: Evaluated as low risk
- extensions.go: Evaluated as low risk
- components.go: Evaluated as low risk
- encoding.go: Evaluated as low risk
- oauth-flows.go: Evaluated as low risk
- path_item.go: Evaluated as low risk
- paths.go: Evaluated as low risk
- contact.go: Evaluated as low risk
- callback.go: Evaluated as low risk
- media_type.go: Evaluated as low risk
Contributor
There was a problem hiding this comment.
Copilot reviewed 17 out of 32 changed files in this pull request and generated no comments.
Files not reviewed (15)
- info.go: Evaluated as low risk
- external-docs.go: Evaluated as low risk
- header.go: Evaluated as low risk
- extensions.go: Evaluated as low risk
- discriminator.go: Evaluated as low risk
- encoding.go: Evaluated as low risk
- example.go: Evaluated as low risk
- path_item.go: Evaluated as low risk
- paths.go: Evaluated as low risk
- components.go: Evaluated as low risk
- oauth-flows.go: Evaluated as low risk
- callback.go: Evaluated as low risk
- contact.go: Evaluated as low risk
- link.go: Evaluated as low risk
- media_type.go: Evaluated as low risk
Comments suppressed due to low confidence (1)
parameter.go:191
- [nitpick] The error message is verbose. It should be simplified to 'must be only one item, but got '%d''.
errs = append(errs, newValidationError(joinLoc(location, "content"), "invalid number of items, expected only one item, but got '%d'", l))
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
SVilgelm
force-pushed
the
examples-validation
branch
from
December 13, 2024 14:10
65d359b to
4d98fea
Compare
Contributor
There was a problem hiding this comment.
Copilot reviewed 17 out of 32 changed files in this pull request and generated no comments.
Files not reviewed (15)
- README.md: Evaluated as low risk
- callback.go: Evaluated as low risk
- components.go: Evaluated as low risk
- contact.go: Evaluated as low risk
- discriminator.go: Evaluated as low risk
- encoding.go: Evaluated as low risk
- example.go: Evaluated as low risk
- extensions.go: Evaluated as low risk
- external-docs.go: Evaluated as low risk
- header.go: Evaluated as low risk
- info.go: Evaluated as low risk
- license.go: Evaluated as low risk
- link.go: Evaluated as low risk
- media_type.go: Evaluated as low risk
- oauth-flows.go: Evaluated as low risk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #20