Skip to content
This repository was archived by the owner on May 4, 2024. It is now read-only.

update regex to allow for urls with equal signs - #6

Merged
skx merged 1 commit into
skx:masterfrom
elatov:master
Jan 21, 2024
Merged

skx merged 1 commit into
skx:masterfrom
elatov:master

Conversation

@elatov

@elatov elatov commented Jan 21, 2024

Copy link
Copy Markdown
Contributor

I ran into an issue where if the destination url had equals signs in it, it would fails to parse. I used https://regexr.com to test it out. Here is the failed use case:

https://regexr.com/7qo18

And here is the working one:

https://regexr.com/7qo1b

I did do a quick build to test it out and it worked out for me. But please let me know if this is an okay change.

Thanks.

@skx
skx merged commit a52cd8e into skx:master Jan 21, 2024
@skx

skx commented Jan 21, 2024

Copy link
Copy Markdown
Owner

Thanks for your contribution, changing to a non-greedy match seems like the perfect solution.

I'll fix the CI and make a new release shortly.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ 换网址