This repository was archived by the owner on May 4, 2024. It is now read-only.
Repository navigation
update regex to allow for urls with equal signs - #6
Merged
Merged
Conversation
Owner
|
Thanks for your contribution, changing to a non-greedy match seems like the perfect solution. I'll fix the CI and make a new release shortly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into an issue where if the destination url had equals signs in it, it would fails to parse. I used https://regexr.com to test it out. Here is the failed use case:
https://regexr.com/7qo18
And here is the working one:
https://regexr.com/7qo1b
I did do a quick build to test it out and it worked out for me. But please let me know if this is an okay change.
Thanks.