Skip to content
This repository was archived by the owner on Sep 10, 2025. It is now read-only.
This repository was archived by the owner on Sep 10, 2025. It is now read-only.

Do not depend on external sites #67

Closed

Description

@nono-gdv

Hello,

Currently several URLs under https://maxcdn.bootstrapcdn.com/, https://code.jquery.com/ and https://cdnjs.cloudflare.com/ are hardcoded in the templates. Would it be possible to expose these URLs are configuration options rather than depending on third parties?

Activity

  1. skx commented on Feb 14, 2020

    @skx
    Owner

    I can appreciate some people might prefer to avoid using those locations, but I'd be a little concerned that adding three new configuration options is a bit much for such a simple project.

    I think the better approach would be to embed the resources in the binary, that way users don't need an external service and I don't need to deal with a potentially growing list of configuration flags.

    (I already do that for /jquery.tablesorter.min.js, though I'd want to make the way that is served more general; probably adding a "404-handler" which will detect requests to routes that are unknown and serve embedded resources if they can be handled that way.)

    Does that seem like a good compromise for you?

  2. nono-gdv commented on Feb 14, 2020

    @nono-gdv
    Author

    Yes, that would be perfect!

  3. self-assigned this
    on Feb 14, 2020
  4. skx commented on Feb 15, 2020

    @skx
    Owner

    Fixed in #68, available in release-1.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

    ⌂ 换网址