Password details logged when DNS lookups fail. #47

We allow users to define tests with parameters, in the input file. The parameters are used for the more specific tests, such as testing SMTP, IMAP, etc.

When a test is executed we submit the result of that test to redis, where it is assumed another component will route the result to the appropriate person (if the test fails. Typically nobody cares about tests that pass).

It has never been an explicit goal of the project to assume any particular deployment, but it has been assumed that results might be sent to "junior" people, so an attempt was made to censor password-parameters that were used in tests, before they were submitted to Redis.

I recently migrated my email from my own server to Google, and once that migration was complete I was suprised to receive an SMS which contained my cleartext password.

Given input like this:

mail.steve.org.uk must run smtp with port 587 with username 'steve' with password 'secret'

I had expected an alert to show with password 'CENSORED'. However there is a case when this censoring doesn't happen: When DNS resolution fails. After my migration was complete I dropped the DNS-record for mail.steve.org.uk, and that meant the test couldn't be executed because the target couldn't be determined. That short-circuited the testing-process and resulted in an alert of the form:

Test failed - mail.steve.org.uk could not be resolved

mail.steve.org.uk must run smtp with port 587 with username 'steve' with password 'secret'

This isn't a major security issue, because there is no explicit threat-model defined, but it is worth noting and fixing for the future.