This repository was archived by the owner on Sep 10, 2025. It is now read-only.
Repository navigation
Improve dependency handling - #83
Merged
Merged
Conversation
Previously we handled dependencies in a naive way:
* For each rule we were to execute
* Get the dependencies of that rule.
* Process the dependencies "kinda"
This worked, but it didn't express recursive dependencies:
rule1 .. which requires rule2 .. which requires rule3 ..
(Specifically we only ran the first dependency, and we didn't
consider the later ones at all.)
This pull-request re-orders the handling so that we will _correctly_
handle rules with multiple dependencies:
* We do **not** detect dependency-cycles explicitly
* However loops/cycles will be broken as we execute rules only once
each time.
* We do not attempt to handle anything with regards to inclusions.
This updates #82.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we handled dependencies in a naive way:
This worked, but it didn't express recursive dependencies:
(Specifically we only ran the first dependency, and we didn't consider the later ones at all.)
This pull-request re-orders the handling so that we will correctly handle rules with multiple dependencies:
This updates #82.