Add mysql module #95

Activity

1. skx

   added

   good first issueGood for newcomersGood for newcomers

   modules

   on Feb 11, 2022
2. alexwhitman commented on Feb 11, 2022

   

   alexwhitman

   on Feb 11, 2022

   Contributor

   More actions

   A mysql module feels a bit specific. It might be better to have a sql module which has an engine attribute to define the database type

   sql {
       engine => "mysql",
       username => "root",
       password => "secret",
       database => "users",
       sql => "SELECT COUNT(id) FROM wp_users WHERE login LIKE \"steve%\"",
   }
   

   This way it allows for adding PostgreSQL, SQLite, Oracle, MSSQL etc without having modules for each.

   Another thought would be to allow the SQL to be defined in a file sql_file => "/path/to/file.sql" which could contain multiple statements to run.

   Something else to think about may be how to deal with SELECT statements vs INSERT/UPDATE/DELETE and if results could/should be useable. There may be cases where some SQL should be run if/unless another SQL query returns a result/value.
3. skx commented on Feb 12, 2022

   

   skx

   on Feb 12, 2022

   OwnerAuthor

   More actions

   Good comment, and definitely agreed that engine-agnostic would be better.

   For any initial attempt I think it would be sufficient to run some SQL. I'd assume that such an action would need to be triggered if it wasn't safe to run multiple times.
4. skx

   added a commit that references this issue on Feb 12, 2022

   Added SQL-module

   ...

   This issue will close once commit aedaf1c is merged into the 'master' branch.

   aedaf1c
5. skx commented on Feb 12, 2022

   

   skx

   on Feb 12, 2022

   OwnerAuthor

   More actions

   Updated to force the user to specify the DB-type and DSN-string.

   Confirmed it works on MySQL & SQLite (memory and on-disk).

   👍React with 👍1Reacted by Alex Whitman
6. skx

   closed this as completedin #99on Feb 13, 2022