Skip to content

Tidy up - #519

Merged
samber merged 1 commit into
samber:masterfrom
NathanBaulch:linting
Aug 21, 2024
Merged

samber merged 1 commit into
samber:masterfrom
NathanBaulch:linting

Conversation

@NathanBaulch

Copy link
Copy Markdown
Contributor

Just some minor tidy up - mostly spelling, grammar, newline inconsistencies, trailing whitespace, redundant types, etc.

Comment thread retry_test.go

is.Equal(iter1, 1)
is.Greater(dur1, 0*time.Millisecond)
is.GreaterOrEqual(dur1, 0*time.Millisecond)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How could be invalid?

I mean this test will always pass. A duration is always positive, no?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be my hardware or the fact that I'm running on Windows, but for me the first call to AttemptWithDelay (which succeeds immediately) returns within the minimum monotonic time period, so these tests always fail.

Comment thread retry_test.go

is.Equal(iter1, 1)
is.Greater(dur1, 0*time.Millisecond)
is.GreaterOrEqual(dur1, 0*time.Millisecond)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same?

@samber

samber commented Aug 20, 2024

Copy link
Copy Markdown
Owner

Wow. That much??

Me, trying to write documentation in English before the Github Copilot era:

@samber

samber commented Aug 20, 2024

Copy link
Copy Markdown
Owner

(tests are broken)

@NathanBaulch

Copy link
Copy Markdown
Contributor Author

Were you aware that I'm Australian before posting that gif? 😛 Don't worry, we don't take ourselves too seriously!
The unit tests should be fixed now.

@samber

samber commented Aug 21, 2024

Copy link
Copy Markdown
Owner

Ahah, sorry. I missed that little detail. 😳 🤣

@samber
samber merged commit db0f4d2 into samber:master Aug 21, 2024
@NathanBaulch
NathanBaulch deleted the linting branch August 22, 2024 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

⌂ 换网址