Repository navigation
fix: preserve release tag during rollback - #224
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: rodri-oliveira-dev/Dapper-FluentMap/https://raw.githubusercontent.com/rodri-oliveira-dev/.github/main/coderabbit-templates/dotnet-library.yaml (via .coderabbit.yaml) Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (8)
🔇 Additional comments (1)
📝 WalkthroughWalkthroughO rollback deixa de aceitar a opção de excluir a tag e passa a mantê-la. O script continua excluindo o GitHub Release e informa que preserva a tag para nova tentativa e recuperação. ChangesRetenção da tag no rollback
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to O rollback preserva a tag validada para novas tentativas e continua removendo o Release parcial. Não há risco acionável identificado para impedir o merge. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 04a5e86381
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
SonarQube Cloud successThe SonarQube Cloud Quality Gate passed for this PR. Quality Gate status: OK
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Summary
Preserves the release tag when a downstream release step fails, instead of deleting it during compensating rollback.
Problem
The previous rollback removed a newly-created release tag after a partial release failure. On
Re-run failed jobs, GitHub reused the successfulCreate release tagjob result instead of recreating the tag, causinggh release create --verify-tagto fail because the tag no longer existed.Changes
-DeleteReleaseTagfromrelease.yml;eng/rollback-release.ps1;Expected behavior
After a partial release failure, the release tag remains bound to the validated commit. A subsequent
Re-run failed jobscan therefore complete the GitHub Release step without depending on the tag-creation job being rerun.Scope
No package IDs, artifacts, versioning rules, publishing credentials, or registry publication semantics were changed.
Summary by CodeRabbit