Repository navigation
Fix GEODIST destination argument validation - #3934
Merged
a-TODO-rov merged 2 commits intoOct 5, 2026
Merged
Conversation
Signed-off-by: Vinod Kumar <codingkiddo@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix GEODIST destination argument validation
RedisCommandBuilder.geodist()checksfromtwice, allowing a nulltoargument to bypass the intended validation.Replace the second check with
toand add regression tests verifyingthat null source and destination arguments produce the appropriate
IllegalArgumentExceptionmessages.Validation:
mvn test -Dtest=RedisCommandBuilderUnitTestsNote
Low Risk
One-line validation fix in command construction; behavior change only rejects previously accepted null
toarguments earlier.Overview
Fixes a copy-paste bug in
RedisCommandBuilder.geodist()where the second null check validatedfromagain instead ofto, so a null destination member could reach Redis instead of failing fast withIllegalArgumentException.Adds
RedisCommandBuilderUnitTestscoverage asserting nullfromand nulltoeach throw with messages "From must not be null" and "To must not be null".Reviewed by Cursor Bugbot for commit fe3ebd6. Bugbot is set up for automated code reviews on this repo. Configure here.