Skip to content

MultiOutput broken for boolean values - #3932

Merged
a-TODO-rov merged 4 commits into
redis:mainfrom
Dgramada:multioutput-broken-for-boolean-values
Oct 6, 2026
Merged

a-TODO-rov merged 4 commits into
redis:mainfrom
Dgramada:multioutput-broken-for-boolean-values

Conversation

@Dgramada

@Dgramada Dgramada commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

This PR implements the MultiOutput.set(boolean) method. Any command whose RESP3 reply is a boolean breaks when it is queued inside MULTI/EXEC (bfAdd, bfExists, vadd, etc.).


Note

Low Risk
Small, localized fix mirroring existing MultiOutput forwarding; risk is mainly regression in transaction result parsing for boolean replies.

Overview
Fixes MULTI/EXEC handling when queued commands return RESP3 boolean replies (#t / #f). MultiOutput already forwarded numeric and bulk replies to the active queued command but did not override set(boolean), so boolean results from commands like bfAdd and bfExists were not applied correctly inside transactions.

The change adds the same peek-and-forward pattern used for other scalar types. Coverage includes unit tests on MultiOutput, RESP3 decode of an EXEC array with booleans, and a bloom-filter transaction integration test; the cluster subclass disables that transaction test because MULTI is not supported there.

Reviewed by Cursor Bugbot for commit e1de943. Bugbot is set up for automated code reviews on this repo. Configure here.

Signed-off-by: yordantsintsov <yordan.tsintsov@gmail.com>
@Dgramada
Dgramada requested a review from a-TODO-rov October 1, 2026 13:57
@Dgramada Dgramada added the type: bug A general bug label Oct 1, 2026
Signed-off-by: yordantsintsov <yordan.tsintsov@gmail.com>
Signed-off-by: yordantsintsov <yordan.tsintsov@gmail.com>

@a-TODO-rov a-TODO-rov left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a-TODO-rov
a-TODO-rov merged commit 276c29c into redis:main Oct 6, 2026
10 of 11 checks passed
@Dgramada
Dgramada deleted the multioutput-broken-for-boolean-values branch October 6, 2026 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug A general bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ 换网址