Repository navigation
MultiOutput broken for boolean values - #3932
Merged
a-TODO-rov merged 4 commits intoOct 6, 2026
Merged
Conversation
Signed-off-by: yordantsintsov <yordan.tsintsov@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the
MultiOutput.set(boolean)method. Any command whose RESP3 reply is a boolean breaks when it is queued inside MULTI/EXEC (bfAdd, bfExists, vadd, etc.).Note
Low Risk
Small, localized fix mirroring existing MultiOutput forwarding; risk is mainly regression in transaction result parsing for boolean replies.
Overview
Fixes MULTI/EXEC handling when queued commands return RESP3 boolean replies (
#t/#f).MultiOutputalready forwarded numeric and bulk replies to the active queued command but did not overrideset(boolean), so boolean results from commands like bfAdd and bfExists were not applied correctly inside transactions.The change adds the same peek-and-forward pattern used for other scalar types. Coverage includes unit tests on
MultiOutput, RESP3 decode of an EXEC array with booleans, and a bloom-filter transaction integration test; the cluster subclass disables that transaction test because MULTI is not supported there.Reviewed by Cursor Bugbot for commit e1de943. Bugbot is set up for automated code reviews on this repo. Configure here.