Repository navigation
Update the docs after 7.7 release - #3896
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5a6dc28a68
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| `bfReserve` can be tuned further with `BfReserveArgs`, and `bfInsert` combines reserve-and-add in a single call: | ||
|
|
||
| ```java | ||
| commands.bfReserve("events", 0.001, 1_000_000, BfReserveArgs.expansion(4).nonScaling()); |
There was a problem hiding this comment.
Call the nested argument builders
When readers copy any of the tuned examples, the code does not compile because these argument classes expose their static entry points through the nested Builder class, not directly on the argument class. Use BfReserveArgs.Builder.expansion(...) and make the same correction for BfInsertArgs, CfReserveArgs, TopKReserveArgs, and TDigestMergeArgs; otherwise all five configuration examples are unusable.
Useful? React with 👍 / 👎.
| CMSInfoValue info = commands.cmsInfo("hits"); | ||
|
|
||
| // Merge several source sketches into a destination (all created with the same dimensions) | ||
| commands.cmsInitByDim("merged", 2000, 5); |
There was a problem hiding this comment.
Initialize the merge destination with matching dimensions
For readers running this example, hits was initialized above using cmsInitByProb(..., 0.001, 0.0001), whose probability-derived depth is not 5, while CMS.MERGE requires identical width and depth for every sketch. Initializing merged as (2000, 5) therefore makes the immediately following merge fail; initialize both sketches with the same explicit dimensions or derive the destination dimensions from cmsInfo.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6fe860cab2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| Boolean added = commands.bfAdd("visitors", "alice"); // true — newly added | ||
| Boolean exists = commands.bfExists("visitors", "alice"); // true | ||
| Boolean missing = commands.bfExists("visitors", "bob"); // false (guaranteed correct) |
There was a problem hiding this comment.
Avoid guaranteeing the result for an unseen item
When the configured filter produces a false positive (up to 1% here), an item that was never added, such as bob, can still make bfExists return true; only a returned false is guaranteed to mean absence. This comment therefore teaches a deterministic result that Bloom filters do not provide, so phrase the guarantee conditionally instead.
Useful? React with 👍 / 👎.
Update the docs after 7.7 release
Note
Low Risk
Documentation and site navigation only; no runtime, API, or security code changes.
Overview
Documents Lettuce 7.7 after release: RedisBloom/probabilistic structures are now listed as natively supported, with a new user guide covering Bloom Filter, Cuckoo Filter, Top-K, Count-Min Sketch, and T-Digest on the standard command APIs.
Also expands the 7.7 “What’s new” list (
SUNIONCARD/SDIFFCARD,LMOVEM/BLMOVEM, streamMAXCOUNT/MAXSIZE,FT.ALIASLIST,VISMEMBER,CLIENT NO-TOUCH) and adds the guide to the MkDocs nav.Reviewed by Cursor Bugbot for commit 3604614. Bugbot is set up for automated code reviews on this repo. Configure here.