Repository navigation
Feature/t digest - #3823
Merged
Merged
Feature/t digest#3823
Conversation
Signed-off-by: yordantsintsov <yordan.tsintsov@gmail.com>
Signed-off-by: yordantsintsov <yordan.tsintsov@gmail.com>
# Conflicts: # src/test/java/io/lettuce/core/cluster/ClusterReadOnlyCommandsUnitTests.java
Signed-off-by: yordantsintsov <yordan.tsintsov@gmail.com>
# Conflicts: # src/main/java/io/lettuce/core/protocol/CommandKeyword.java # src/main/kotlin/io/lettuce/core/api/coroutines/RedisCoroutinesCommands.kt # src/test/java/io/lettuce/apigenerator/Constants.java # src/test/java/io/lettuce/core/cluster/ClusterReadOnlyCommandsUnitTests.java
Signed-off-by: yordantsintsov <yordan.tsintsov@gmail.com>
Signed-off-by: yordantsintsov <yordan.tsintsov@gmail.com>
Signed-off-by: yordantsintsov <yordan.tsintsov@gmail.com>
Signed-off-by: yordantsintsov <yordan.tsintsov@gmail.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
Reviewed by Cursor Bugbot for commit c506cab. Configure here.
Signed-off-by: yordantsintsov <yordan.tsintsov@gmail.com>
Signed-off-by: yordantsintsov <yordan.tsintsov@gmail.com>
…lueParserUnitTests. Signed-off-by: yordantsintsov <yordan.tsintsov@gmail.com>
Signed-off-by: yordantsintsov <yordan.tsintsov@gmail.com>
# Conflicts: # src/main/java/io/lettuce/core/AbstractRedisAsyncCommands.java # src/main/java/io/lettuce/core/AbstractRedisReactiveCommands.java # src/main/java/io/lettuce/core/api/async/RedisAsyncCommands.java # src/main/java/io/lettuce/core/api/reactive/RedisReactiveCommands.java # src/main/java/io/lettuce/core/api/sync/RedisCommands.java # src/main/java/io/lettuce/core/cluster/api/async/NodeSelectionAsyncCommands.java # src/main/java/io/lettuce/core/cluster/api/async/RedisClusterAsyncCommands.java # src/main/java/io/lettuce/core/cluster/api/reactive/RedisClusterReactiveCommands.java # src/main/java/io/lettuce/core/cluster/api/sync/NodeSelectionCommands.java # src/main/java/io/lettuce/core/cluster/api/sync/RedisClusterCommands.java # src/main/java/io/lettuce/core/protocol/CommandType.java # src/main/java/io/lettuce/core/protocol/ReadOnlyCommands.java # src/main/kotlin/io/lettuce/core/api/coroutines/RedisCoroutinesCommands.kt # src/main/kotlin/io/lettuce/core/api/coroutines/RedisCoroutinesCommandsImpl.kt # src/main/kotlin/io/lettuce/core/cluster/api/coroutines/RedisClusterCoroutinesCommands.kt # src/main/kotlin/io/lettuce/core/cluster/api/coroutines/RedisClusterCoroutinesCommandsImpl.kt # src/test/java/io/lettuce/core/cluster/ClusterReadOnlyCommandsUnitTests.java
Signed-off-by: yordantsintsov <yordan.tsintsov@gmail.com>
a-TODO-rov
approved these changes
Aug 13, 2026
| super(codec); | ||
| } | ||
|
|
||
| Command<K, V, String> tdigestAdd(K key, V value) { |
Collaborator
There was a problem hiding this comment.
Suggested change
| Command<K, V, String> tdigestAdd(K key, V value) { | |
| Command<K, V, String> tdigestAdd(K key, double value) { |
| } | ||
|
|
||
| @SafeVarargs | ||
| final Command<K, V, String> tdigestAdd(K key, V... values) { |
Collaborator
There was a problem hiding this comment.
Suggested change
| final Command<K, V, String> tdigestAdd(K key, V... values) { | |
| final Command<K, V, String> tdigestAdd(K key, double... values) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Adds support for Redis T-Digest Sketch commands.
Commands:
mvn formatter:formattarget. Don’t submit any formatting related changes.Note
Low Risk
Additive API and protocol support with no changes to auth or core connection logic; risk is mainly breadth of new surface area and correct RESP decoding for special doubles.
Overview
Adds full client support for Redis T-Digest (
TDIGEST.*) across sync, async, reactive, Kotlin coroutines, and cluster node-selection APIs, following the same layout as other probabilistic modules (CMS, Top-K).New pieces include
RedisTDigestCommandBuilder,TDigestInfoValue/ parser,TDigestMergeArgs(COMPRESSION,OVERRIDE), protocol entries inCommandTypeand read-only routing, plus integration and unit tests.Supporting tweaks:
DoubleOutput/DoubleListOutputnow decode bulk-string doubles viaLettuceStrings.toDouble(so Redisnan/infwork);LettuceAssertgainsnotEmptyforlong[]anddouble[]. Top-K test classes were moved fromprobabilistic.topktoprobabilistic(package-only).Reviewed by Cursor Bugbot for commit e505878. Bugbot is set up for automated code reviews on this repo. Configure here.